Function Call in IF Condition

Question

I want to check the function call in "IF condition", but it's not working. I'm getting the output as "undefined "My program output supposed to be: If user Select a car, then response will be accordingly. Is my method to get value is wrong?

function carPickUp() {
  var pickedCar = document.getElementById("cars").value;
  return pickedCar;
}

function showCar() {
  var message;
  if (carPickUp() == "ROLLS") {
    message = "Great choice";
  } else if (carPickUp() == "AUDI") {
    message = "best choice";
  } else if (carPickUp() == "VOLVO") {
    message = "Good choice";
  } else if (carPickUp() == "FORD") {
    message = "Good choice";
  }
  document.getElementById("demo1").innerHTML = message;
}

<h2>The select Element</h2>
<p>The select element defines a drop-down list:</p>
<form action="/action_page.php">
  <label for="cars">Choose a car:</label>
  <select id="cars" name="cars">
    <option value="volvo">VOLVO</option>
    <option value="ford">FORD</option>
    <option value="rolls">ROLLS</option>
    <option value="audi">AUDI</option>
  </select>
  <input type="button" onclick="showCar()" value="Submit" />
</form>
<p id="demo1"></p>

You have lowercase values and uppercase text but you check the value — mplungjan, Mar 30 '20 at 17:15
Upper-case letters are different from lower-case letters; your `value` attributes all have lower-case values. — Pointy, Mar 30 '20 at 17:15
Also DRY: `let message = "Unknown value for car; const value = carPickUp(); if (value==="rolls") message = "Great choice"; ...` — mplungjan, Mar 30 '20 at 17:17
Or use a lookup table: `const lookup = ["rolls":"Great choice","audi":"Best choice",.....]; message = lookup[value];` — mplungjan, Mar 30 '20 at 17:19

Function Call in IF Condition

0 Answers0