PHP Laravel 5.6.39 - "Trying to get property of non-object" when trying to view an invoice on application

Question

Hey guys here is my first question on stack overflow.

I am getting the following error message:

Trying to get property of non-object

When I am trying to view a refunded invoice within the system. Any help is much appreciated it! Thank you so much!

Here is the full code on the file:

   <?php

namespace App\Http\Controllers;

use App\Addon;
use App\Invoice;
use App\Package;
use Illuminate\Support\Facades\DB;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Session;

use App\PackagesCustomPrices;
use App\BookingSlot;
use App\BookingTime;
use App\Booking;

use Dompdf\Dompdf;

use App\Exports\InvoiceExport;
use Excel;


class AdminInvoicesController extends Controller
{

    /*
    |--------------------------------------------------------------------------
    | Admin Invoices Controller
    |--------------------------------------------------------------------------
    |
    | This controller is responsible for providing invoices views to admin.
    |
    */

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function export()
    {
        return Excel::download(new InvoiceExport, 'invoices.xlsx');
    }


    public function index()
    {

        $invoices = Invoice::select('invoices.*', 'bookings.first_name as first_name', 'bookings.last_name as last_name', 'bookings.id as booking_id', 'bookings.phone as phone')
                    ->join('bookings', 'bookings.id', 'invoices.booking_id')
                    ->where('invoices.archived', 0)->with('booking')->get();
        return view('invoices.index', compact('invoices'));
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $invoice = Invoice::findOrFail($id);

        //get package and addons
        $package = Package::find($invoice->booking->package->id);
        $addons = DB::table('addon_booking')->where('booking_id', '=', $invoice->booking_id)->get();

    //    $package_custom = PackagesCustomPrices::where('package_id','=',$invoice->booking->package->id)->first();

        $exp_booking = explode(" - ",$invoice->booking->booking_time);

        list($month,$day,$year) = explode('-', $invoice->booking->booking_date);
        $timestamp = mktime(0, 0, 0, $month, $day, $year);
        $event_date =  date('d-m-Y', $timestamp);

        //get day name to select slot timings
        $timestamp_for_event = strtotime($event_date);
        $today_number = date('N', $timestamp_for_event);        

        $its_holiday = BookingTime::where('today_is','=',$invoice->booking->booking_date)->first();
        if(isset($its_holiday->id))
        {
            $today_number = $its_holiday->id;
        }

        $get_slot = BookingSlot::where('opening','=',trim($exp_booking[0]))->where('closing','=',trim($exp_booking[1]))->where('booking_time_id','=',$today_number)->first();

        $package_custom = PackagesCustomPrices::where('package_id','=',$invoice->booking->package->id)->where('slot_id','=',$get_slot->id)->first();

        if(isset($package_custom->price))
        {
            $total = $package_custom->price;
        }
        else
        {
            $total = $package->price;
        }

        $invoice->booking->package->price = $total;
        //calculate total

        //add addons price if any
        // foreach($addons as $addon)
        // {
        //     $total = $total + Addon::find($addon->addon_id)->price;
        // }

        if($invoice->promo_discount)
        {
            $coupon = \App\CouponCode::where('code', $invoice->promo_used)->first();
            if($coupon->extra_items == 0){
                if($invoice->promo_discount)
                {
                    $discount = ($invoice->promo_discount / 100) * $total;
                    $total = $total - $discount;
                }

                foreach($addons as $addon)
                        {
                            $total = $total + Addon::find($addon->addon_id)->price;
                        }
            }
            else{

                foreach($addons as $addon)
                {
                    $total = $total + Addon::find($addon->addon_id)->price;
                }

                if($invoice->promo_discount)
                {
                    $discount = ($invoice->promo_discount / 100) * $total;
                    $total = $total - $discount;
                }
            }
        }
        else{
            foreach($addons as $addon)
            {
                $total = $total + Addon::find($addon->addon_id)->price;
            }
        }

        // print_r($total);

        // if($invoice->promo_discount)
        // {
        //     $discount = ($invoice->promo_discount / 100) * $total;
        //     $total = $total - $discount;
        // }

        // print_r($discount);
        // print_r($total);
        // exit();

        if(!$invoice->promo_discount && config('settings.enable_gst'))
        {
            $gst_amount = round(( config('settings.gst_percentage') / 100 ) * $total, 2);
        }

        else if($invoice->promo_discount && config('settings.enable_gst'))
        {
            if(config('settings.paypal_processing_fee') && $invoice->payment_method == __('app.paypal')){
                $total = $invoice->amount - (float) config('settings.paypal_processing_fee');
                // print_r($total);
                $gst_amount = round(( config('settings.gst_percentage') / 100 ) * $total, 2);
            }
            elseif (config('settings.stripe_processing_fee') && $invoice->payment_method == __('app.credit_card')) {
                $total = $invoice->amount - (float) config('settings.stripe_processing_fee');
                // print_r($total);
                $gst_amount = round(( config('settings.gst_percentage') / 100 ) * $total, 2);
            }
        }

        else
        {
            $gst_amount = 0;
        }
        // exit();

        return view('invoices.view', compact('invoice','gst_amount', 'total', 'discount'));
    }

    public function print($id)
    {
        $invoice = Invoice::findOrFail($id);

        //get package and addons
        $package = Package::find($invoice->booking->package->id);
        $addons = DB::table('addon_booking')->where('booking_id', '=', $invoice->booking_id)->get();


    //    $package_custom = PackagesCustomPrices::where('package_id','=',$invoice->booking->package->id)->first();

        $exp_booking = explode(" - ",$invoice->booking->booking_time);

        list($month,$day,$year) = explode('-', $invoice->booking->booking_date);
        $timestamp = mktime(0, 0, 0, $month, $day, $year);
        $event_date =  date('d-m-Y', $timestamp);

        //get day name to select slot timings
        $timestamp_for_event = strtotime($event_date);
        $today_number = date('N', $timestamp_for_event);        

        $its_holiday = BookingTime::where('today_is','=',$invoice->booking->booking_date)->first();
        if(isset($its_holiday->id))
        {
            $today_number = $its_holiday->id;
        }


        $get_slot = BookingSlot::where('opening','=',trim($exp_booking[0]))->where('closing','=',trim($exp_booking[1]))->where('booking_time_id','=',$today_number)->first();



                $package_custom = PackagesCustomPrices::where('package_id','=',$invoice->booking->package->id)->where('slot_id','=',$get_slot->id)->first();        


        if(isset($package_custom->price))
        {
            $total = $package_custom->price;
        }
        else
        {
            $total = $package->price;
        }
        //calculate total
        $invoice->booking->package->price = $total;

        //add addons price if any
        foreach($addons as $addon)
        {
            $total = $total + Addon::find($addon->addon_id)->price;
        }

        if($invoice->promo_discount)
        {
            $discount = ($invoice->promo_discount / 100) * $total;
            $total = $total - $discount;
        }

        if(config('settings.enable_gst'))
        {
            $gst_amount = round(( config('settings.gst_percentage') / 100 ) * $total, 2);
        }
        else
        {
            $gst_amount = 0;
        }

        // instantiate and use the dompdf class
        // print_r(base_path() . "/vendor/autoload.php");

        require base_path() . "/vendor/autoload.php";

        $dompdf = new Dompdf();
        $dompdf->set_option('isHtml5ParserEnabled', true);

        $view_hello = view('invoices.print', compact('invoice','gst_amount', 'total', 'discount'));  

        $dompdf->loadHtml(utf8_decode($view_hello));

        // (Optional) Setup the paper size and orientation
        $dompdf->setPaper('A4', 'portrait');

        // Render the HTML as PDF
        $dompdf->render();

        // Output the generated PDF to Browser
        $dompdf->stream("welcome.".date("ymdhis").".pdf", array("Attachment"=>0));


        //return view('invoices.view', compact('invoice','gst_amount', 'total', 'discount'));        
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $invoice = Invoice::find($id);

        $invoice->update([
            'is_paid' => 1
        ]);

        return redirect()->route('invoices.index');
    }


    public function delete_all(Request $request)
    {
        $values = explode(',', $request->delete_values);

        // print_r($values);
        // exit();

        foreach ($values as $value) {
            if($value === null || empty($value)){
                continue;
            }
                $invoice = Invoice::findorFail($value);

                $booking = Booking::find($invoice->booking_id);
                if($booking){
                    $booking->addons()->detach();
                    $booking->delete();
                }


                //delete event if google calendar sync is enabled
                if(config('settings.sync_events_to_calendar') && config('settings.google_calendar_id') && $booking->google_calendar_event_id != NULL)
                {
                    try {
                        //remove google calendar event
                        $event = Event::find($booking->google_calendar_event_id);
                        $event->delete();
                    } catch(\Exception $ex) {
                        //do nothing
                    }
                }

                $invoice->delete();
        }

        Session::flash('booking_deleted', __('backend.invoice_deleted'));
        return redirect()->route('invoices.index');
    }

}

The line of code that contains the error is below:

$package_custom = PackagesCustomPrices::where('package_id','=',$invoice->booking->package->id)->where('slot_id','=',$get_slot->id)->first();

Answer 1

In short you are trying to get a property value of a variable that has no value. From your code it can be from either $invoice or $get_slot.

The first step is to find out which variables have the problem. dd() is great for that as dd = stands for die and dump, which simply returns the value and halts the execution.

So you need to insert dd() right before your problem line:

$get_slot = BookingSlot::where('opening','=',trim($exp_booking[0]))->where('closing','=',trim($exp_booking[1]))->where('booking_time_id','=',$today_number)->first();

dd($invoice);
dd($invoice->booking);
dd($invoice->booking->package);
dd($get_slot);

$package_custom = PackagesCustomPrices::where('package_id','=',$invoice->booking->package->id)->where('slot_id','=',$get_slot->id)->first();

Now keep in mind that dd() will die after it dumps, so you will only see the return of the first value you tested.

So if dd($invoice) returns a value, then just comment it out like:

$get_slot = BookingSlot::where('opening','=',trim($exp_booking[0]))->where('closing','=',trim($exp_booking[1]))->where('booking_time_id','=',$today_number)->first();
// dd($invoice);
dd($invoice->booking);
dd($invoice->booking->package);
dd($get_slot);

$package_custom = PackagesCustomPrices::where('package_id','=',$invoice->booking->package->id)->where('slot_id','=',$get_slot->id)->first();

If that one returns a value then continue commenting out until you find the one that is null.

So let's say that the problem is with $get_slot, then you can dump the sql query to work out what the problem is.

You could do that getting the SQL of $get_slot query before the $get_slot line with:

$query = BookingSlot::where('opening','=',trim($exp_booking[0]))->where('closing','=',trim($exp_booking[1]))->where('booking_time_id','=',$today_number)->toSql();
dd($query);

$get_slot = BookingSlot::where('opening','=',trim($exp_booking[0]))->where('closing','=',trim($exp_booking[1]))->where('booking_time_id','=',$today_number)->first();

Take this query to your SQL client to try to figure out why it's not returning a value. Which of course can be that $today_number or $exp_booking don't have what you expect, or you are missing data, or you have an issue with the design of your DB. But that gives you the tools to work out what the issue is.

Answer 2

almost $invoice or$get_slot is empty or return array object or have not the wanted property so you cannot get property from object . you can use if(!empty($invoice)&&!empty($get_slot)) to check not empty object. you can also use dd() function to know returned data in each object.

Answer 3

if ($invoice && $invoice->booking && $invoice->booking->package && $get_slot){
    $package_custom = PackagesCustomPrices::where('package_id','=',$invoice->booking->package->id)->where('slot_id','=',$get_slot->id)->first();
}

one of the variables can be null. You should check

Answer 4

The best way to handle this sort of problem is to read the error message very literally, and work back to the answer from there: Trying to get a property of a non-object First we look for a property in the indicated line of code where we learn we need to make sure $invoice, $invoice->booking, $invoice->booking->package, and $get_slot all exist.

I'm certain that $invoice is null. If that's the whole code body of the file, as you say in your question, then $invoice is never defined.

Before this line:

$package_custom = PackagesCustomPrices::where('package_id','=',$invoice->booking->package->id)->where('slot_id','=',$get_slot->id)->first();

Add this:

dd($invoice);

and go from there.