How to correctly use Android View Binding in DialogFragment?

Question

What is correct way of using Android View Binding in DialogFragment()?

Official documentation mentions only Activity and Fragment: https://developer.android.com/topic/libraries/view-binding

hamrosvet · Accepted Answer · 2020-12-10T09:27:54.307

56

Use inflate(LayoutInflater.from(context)) instead. And use binding.root to set the builder view.

Also, as Google suggests, it's best practice to set the binding instance to null at onDestroyView() when using fragments: https://developer.android.com/topic/libraries/view-binding#fragments

Example:

class ExampleDialog : DialogFragment() {

    private var _binding: DialogExampleBinding? = null
    // This property is only valid between onCreateDialog and
    // onDestroyView.
    private val binding get() = _binding!!

    override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
        _binding = DialogExampleBinding.inflate(LayoutInflater.from(context))
        return AlertDialog.Builder(requireActivity())
            .setView(binding.root)
            .create()
    }
    
    override fun onDestroyView() {
        super.onDestroyView()
        _binding = null
    } 
}

edited Dec 10 '20 at 09:27

answered Apr 30 '20 at 03:24

hamrosvet

1,178
12
15

4

This is recommended to prevent crashes but what happens if binding is used after it is set to null? I think it will crash, which means `private val binding get() = _binding!!` makes no sense at all. Am I missing something? – Mehmed Dec 18 '20 at 09:43
1

You shouldn't use the view once it reaches the onDestroyView life cycle. – Nino DELCEY Jun 21 '21 at 12:01
3

Also, it is a better pratice to use your binding as a local variable. No need to override onDestroyView in this case ! :) – Nino DELCEY Jun 21 '21 at 12:03
This will crash sometimes as @Mehmed said. – The Dongster Jul 27 '22 at 04:20
Is `onDestroyView` necessary for _binding? – IgorGanapolsky Nov 02 '22 at 12:15
use lateinit for global, and without need of global variable, just use locally inside onviewcreated – The Dongster Nov 12 '22 at 03:24
What should I do in case I use FragmentViewBindingDelegate in this case of DialogFragment? – android developer Dec 19 '22 at 10:59
1

@IgorGanapolsky, yes. When a fragment recreates a view, it's `_binding` receives a new value. To detect where a view is destroyed, check `_binding == null` (for instance, after long loading operations). – CoolMind Jul 21 '23 at 09:13

How to correctly use Android View Binding in DialogFragment?

1 Answers1

Linked