Trouble Dealing a card object to a player object's hand in Blackjack

Question

I'm trying to develop a simple BlackJack game with Python.I'm at the stage where I want to deal a single card to the dealer's hand (a list in the dealer class) and the player's hand(a list in the player's class). When I deal to the dealer there is no problem however I have the players that are in a list called playerSet, I use a for loop to pop a card from the deck and append it to each player's hand. The problem is that each time I try to append to one player's hand the cards are duplicated to each player's hand.

This is some of the relevant code:

def DealCards():
    global BlackJackDeck
    Dealer1.addToHand(BlackJackDeck.drawCard())
    #Would love to know why same card is ent to both decks
    for i in range(0,len(playerSet)):
        playerSet[i].addToHand(BlackJackDeck.drawCard())
        break

This is the draw method located in the deck class

def drawCard(self):
        #may need to change this method
        return self.Deck.pop()

In terms of the player's class this is how the hand is declared as a list

class player(object):
    name = None
    Token = int(500)
    score = 0
    bet = 0
    hand = []

    def __init__(self,name):
        self.name = name

This is the method used to add a card to a player's hand - A list in the player class

def addToHand(self,card):
        if isinstance(card,Card):
                self.hand.append(card)
        else: 
            print("This is not a Card..")

The Blackjack deck is just an instance of the deck class which I will attach below

BlackJackdeck =Deck()

from Card import Card
import random

class Deck():
    Deck=[]
    def __init__(self):
         self.Deck =[]
         self.build()

    def build(self):

        for s in ["Hearts", "Spades", "Diamonds","Clubs"]:
            for v in range(1,14):
                if v>10:
                    for royalty in ["Jack","Queen", "King"]:
                        self.Deck.append(Card("{} of {}".format(royalty,s),s,10))
                    break
                else:
                    self.Deck.append(Card("{} of {}".format(v,s),s,v))

    def view(self):
        for view in self.Deck:
            #view.printer()
            #print("{} of {} ".format(view.value, view.suit))
            print("{}".format(view.name))

    def drawCard(self):
        #may need to change this method
        return self.Deck.pop()


    def shuffle(self):
        random.shuffle(self.Deck)


    def returnHand(self,playerHand=[]):
        if len(self.Deck)>52:
            print(f"Player hand couldn't be added there are too many cards in the deck {playerHand}")
        elif len(self.Deck)+len(playerHand)<=52:
            self.Deck.append(playerHand)

I also think that for for some reason all of the instantiated player objects either have the same hand or they are having the same card objects to their hand respectively and I can't figure out why.

Answer 1

Maybe you can show more code? Specifically, how the BlackJackDeck is initialized. Also, how are the players' hands initialized? I'll update this answer once we get more information. For now, it's hard to say what's going on without seeing more.

Here's an unrelated thing that caught my attention, however: list.pop takes an optional integer parameter which it treats as the index from which to pop. The way your code is written, it seems that you are under the impression that this number represents the number of items you wish to pop, which is incorrect. Therefore, when you say BlackJackDeck.drawCard(1), you are popping and returning the card at index 1 (the second card). If you say BlackJackDeck.drawCard(5), you are not popping five cards from the deck, you are popping a single card - the card at index 5 (the sixth card).

EDIT - Thanks for posting more of your code. The major problem that sticks out right away is the fact that each player's hand is not an instance variable, it's a (static) class variable. Take a look at this snippet, which is meant to simulate the structure your code has right now:

class Player:
    hand = []

    def __init__(self, name):
        self.name = name

    def add_card_to_hand(self, card):
        self.hand.append(card)


player_1 = Player("Bob")
player_2 = Player("Tom")

player_1.add_card_to_hand("Ace of Spades")
player_2.add_card_to_hand("Queen of Hearts")

print(f"{player_1.name}'s hand: {player_1.hand}")
print(f"{player_2.name}'s hand: {player_2.hand}")

Output:

Bob's hand: ['Ace of Spades', 'Queen of Hearts']
Tom's hand: ['Ace of Spades', 'Queen of Hearts']
>>> 

hand is a single list in memory that's shared across all Player instances, because it's a class variable. Therefore, if you invoke add_card_to_hand, regardless of what player object you're referring to, you end up appending to the same list. What you really want is a separate list for each player, so hand should be an instance variable, like this:

class Player:

    def __init__(self, name):
        self.hand = []
        self.name = name

    def add_card_to_hand(self, card):
        self.hand.append(card)


player_1 = Player("Bob")
player_2 = Player("Tom")

player_1.add_card_to_hand("Ace of Spades")
player_2.add_card_to_hand("Queen of Hearts")

print(f"{player_1.name}'s hand: {player_1.hand}")
print(f"{player_2.name}'s hand: {player_2.hand}")

Output:

Bob's hand: ['Ace of Spades']
Tom's hand: ['Queen of Hearts']
>>> 

I'll look at the rest of the code you posted in bit. If I see anything else I'll update this post.