Create and write into the txt file with one button

Question

I would like to create the txt file that has name from my textbox1 and at the same time, I would like to write in it text from my textbox2.

Can you help me?

I have tried this

private void button1_Click(object sender, EventArgs e)
{
    string path = @"C:\Users\felc\Desktop\file\" + textBox1.Text + 
     ".txt";

    File.Create(path);

    using (var tw = new StreamWriter(path, true))
    {
        tw.WriteLine(textBox1.Text);
    }
}

And what is the problem? The only issue I see is that you are writing the text of `textBox1` instead of `textBox2` — UnholySheep, Apr 18 '20 at 14:51
When I try to save it, txt file will crete but nothing is in there. The error is saying that another procces is using the txt. — Klára Ročová, Apr 18 '20 at 14:54
Consider using `System.IO.Path.Combine()` for concatenating file paths. Manual concatenation is prone to errors. — Patrick Tucci, Apr 18 '20 at 14:54
@KláraRočová [`File.Create()` is locking the file](https://stackoverflow.com/questions/4680284/system-io-file-create-locking-a-file). It's also not necessary. When creating a `StreamWriter` for a given file path, the file is created if it doesn't already exist. — Patrick Tucci, Apr 18 '20 at 14:55
@PatrickTucci I removed the File.Create(path); and it seems to work fine. Thanks — Klára Ročová, Apr 18 '20 at 14:59

score 0 · Answer 1 · answered Apr 18 '20 at 15:05

I would suggest you first check if the file already exists, and only create it if not. Something like:

private void button1_Click(object sender, EventArgs e)
{

    string path = @"C:\Users\felc\Desktop\file\" + textBox1.Text + ".txt";

    if (!File.Exists(path))
    {
        File.Create(path);
    }

    using(var tw = new StreamWriter(path, false))
    {
        tw.WriteLine(textBox2.Text);
    }
}

Note : in case you would like your code to append line to the file and not to re-write it, change the secont argument to "true": new StreamWriter(path, true)

Note 2 : You wrote the value of the first text box to the file instead of the second one. hence, in your code the text in the file will be the same as it's name.

score 0 · Answer 2 · answered Apr 18 '20 at 16:01

0

 using(var tw = new StreamWriter(path, false))
{
    tw.WriteLine(textBox2.Text);
}

answered Apr 18 '20 at 16:01

Avijit Atta

11
1

1

Thanks for answering a question - can you add some explanation to help OP understand what it is about your answer that solves the problem. It also makes the site more useful for people (of various levels of experience) who might come across the question later. – Joe Mayo Apr 19 '20 at 01:12

Create and write into the txt file with one button

2 Answers2