Unity Sword Collision Attack

Question

Hey guys I want to make a sword attack. But I get the error of:

NullReferenceException: Object reference not set to an instance of an object

These are my codes: My weaponattack script:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class Weaponattack : MonoBehaviour
{
    Enemy Enemy;
    public float power;
    // Use this for initialization
    void Start () {

    }
    // Update is called once per frame
    void Update () {

    }
    public void OnTriggerEnter(Collider col)
    {
       if(col.tag == "Enemy")
        {
            var kılıc = GetComponent<Enemy>();
            Enemy.currentHealt -= 10;
            Enemy.TakeDamage();
            Debug.Log("Düşman Vuruldu");
        }
    }
}

This is my Enemy Health scrpt:

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class Enemy : MonoBehaviour {
    public float currentHealt;
    public float maxHealth;
    // Use this for initialization
    void Start () {
        currentHealt = maxHealth;
    }

    // Update is called once per frame
    void Update () {

    }
    public void TakeDamage()
    {
        currentHealt -= 10;
        if(currentHealt < 0)
        {
            die();
        }
    }
    void die()
    {
        Destroy(gameObject);
    }
}

Can you helo em I couldnt understan why these codes are not working why am I getting that error.

Does this answer your question? [What is a NullReferenceException, and how do I fix it?](https://stackoverflow.com/questions/4660142/what-is-a-nullreferenceexception-and-how-do-i-fix-it) — BugFinder, Apr 23 '20 at 22:34

Jay · Accepted Answer · 2020-04-24T17:59:34.503

2

I think your problem is in this line here GetComponent<Enemy>(); This needs a game object to get the component of

Enemy = col.GetComponent<Enemy>();

Should be what you're doing

You also may have issue calling your variable Enemy exactly the same as your class Enemy, I would change this to Enemy enemy; and

enemy = col.GetComponent<Enemy>();

respectivley

edited Apr 24 '20 at 17:59

answered Apr 23 '20 at 23:39

Jay

2,553
3
17
37

Yes thanks it worked. Yes it is very basic code but instead of writing lots codes I would rather this. – Alp Eren Gül Apr 24 '20 at 11:27

jiveturkey · Answer 2 · 2020-04-23T19:49:48.200

0

It seems pretty straightforward. You don't assign an Enemy to Weaponattack and so it's barfing when you first reference Enemy (Enemy.currentHealt). Either make Enemy public or a SerializedField so you can assign it in the Inspector, or however else you want to get an Enemy into Weaponattack.

Also don't name your property the same name as your script (Enemy Enemy). Surprised you didn't get a compile error.

EDIT Based on comments:

Enemy enemy;


public void OnTriggerEnter(Collider col)
{
   if(col.tag == "Enemy")
    {
        var kılıc = GetComponent<Enemy>();
        kilic.currentHealt -= 10;
        kilic.TakeDamage();
        Debug.Log("Düşman Vuruldu");
    }
}

This also assumes you have an Enemy attached to your Weaponattack (GetComponent)

edited Apr 23 '20 at 19:49

answered Apr 23 '20 at 19:27

jiveturkey

2,484
1
23
41

var kılıc = GetComponent(); kılıc.currentHealt -= 10; – Alp Eren Gül Apr 23 '20 at 19:44
When I changed it like this it doesnt work again. Can you show a code block abour acsessing ? – Alp Eren Gül Apr 23 '20 at 19:44
So why aren't you using `kilic`? Enemy is still unassigned. Also, it's very confusing which `Enemy` you are talking about. It appears as if `TakeDamage` and `currentHealt` are static. – jiveturkey Apr 23 '20 at 19:48

Unity Sword Collision Attack

2 Answers2