How to get rid of a new line after string

Question

I was trying to print a string and an integer using array of structs and code seems to be fine, but in the output instead of 1 line of values, after each string a new line is automatically added. Can someone please help?

#include <stdio.h>

typedef
    struct player_main{
        char name[20];
        int total;
    }
player;

void print(player pprint);
void scan(player *pscan);

int main(){
    player user[2];
    for(int i = 0; i < 2; i++){// scanned
        printf("Player %d", i+1);
        scan(&(user[i]));
    }
    for(int i = 0; i < 2; i++){// printed
        print(user[i]);
    }

    return 0;
}
void print(player pprint){
    printf("%s Weight:%d kg\n", pprint.name, pprint.total);

}
void scan(player *pscan){
    printf("\nName: \n");
    fgets(pscan->name, 20, stdin);
    printf("\nEnter weight:");
    scanf("%d%*c", &(pscan->total));

}

Example of desired output:

Player A, 50 kg    Player B, 60 kg

Actual output:

Player A,
50 kg
Player B,
60 kg

This can't be you actual output. It does not match the code. — Eugene Sh., Apr 24 '20 at 17:26
@EugeneSh.It could, if the player name was `A,\n` (i.e. with a trailing newline), which using `fgets()` would do. — TripeHound, Apr 24 '20 at 17:30
@EugeneSh. You're right... I was focused on the newlines :-) — TripeHound, Apr 24 '20 at 17:31
@EugeneSh Thanks very much! And yes the word Weight isn't where it must be as it was just an example output, sorry for that — Maxim Daïneko, Apr 24 '20 at 17:35
@AhmadLabouff all you have to do is substitute a single char to the string obtained with fgets. I answered [to a similar question](https://stackoverflow.com/a/58853207/11336762) some times ago. — Roberto Caboni, Apr 24 '20 at 17:41

score 1 · Answer 1 · answered Apr 24 '20 at 17:31

1

fgets adds \n (the 'enter' you press) to the buffer.

You can use strchr to replace it with '\0';

void scan(player *pscan){
    ...
    *strchr(pscan->name, '\n') = '\0';
    ...
}

answered Apr 24 '20 at 17:31

MrBens

1,227
1
9
19

score 1 · Answer 2 · answered Apr 24 '20 at 17:33

1

fgets also reads the newline character into the buffer, you will need to remove it:

//...
fgets(pscan->name, 20, stdin);
pscan->name[strcspn(pscan->name, "\n")] = '\0';
//...

Include string.h.

Running code

answered Apr 24 '20 at 17:33

anastaciu

23,467
7
28
53

How to get rid of a new line after string

2 Answers2