PHP error: Unparenthesized `a ? b : c ? d : e` is deprecated

Question

Hi I'm stuck on this error message. I tried to encapsulate it with parenthesis still I got an error on this specific line.

   <li class="{{ (\Request::is('stocks/*') ? ' open' : Request::is('stocks') ? ' open' : Request::is('defective/*') ? ' open' : '')  }}">

It works on local, yet after Iv'e deployed it to heroku the error occurs.

Quick note: from https://www.php.net/manual/en/language.operators.comparison.php: "_It is recommended that you avoid "stacking" ternary expressions. PHP's behaviour when using more than one ternary operator within a single statement is non-obvious_" — brombeer, May 11 '20 at 06:03
You need to think about how these parts of the expression are grouped together, this is not just for the system to work it out, but also for the poor developer after you which has got to maintain this code. — Nigel Ren, May 11 '20 at 06:08

score 2 · Accepted Answer · answered May 11 '20 at 05:29

It looks like you put the parentheses in the wrong place. Try this:

<li class="{{ (\Request::is('stocks/*') ? ' open' : ( Request::is('stocks') ? ' open' : ( Request::is('defective/*') ? ' open' : '' ) ) ) }}">

You also may be able to simplify it:

<li class="{{ ( ( \Request::is('stocks/*') || Request::is('stocks') || Request::is('defective/*') ) ? ' open' : '' ) }}">

1 Answers1