Java If Else Text Based on Other Text

Question

I am trying to have a text-box populate with X if another text-box has a certain value, else Y. However, it's populating with X or Y seemingly randomly. d4 is my button, d4result is where it populates the result, d4txt1 is where I want to see a 1 or 0, depending.

d4.setOnClickListener {
        if  (d4result.text.toString() == "1") {
            d4txt1.text = "1"
        } else {
            d4txt1.text = "0"
        }
        val rand = Random().nextInt(4) + 1
        d4result.text = rand.toString()
    }

So if d4result is populated with 1, I want d4txt1 to populate with 1, otherwise it should be zero. But when I try it, I get 1 or 0 and I can't notice a pattern as to when/why.

Muazzam A. · Answer 1 · 2020-05-13T01:02:38.787

Use equals instead of ==. == operator will return true only if two object reference it is comparing represent exactly same object otherwise "==" will return false.

d4.setOnClickListener {
        if  (d4result.text.toString().equalsIgnoreCase("1")) {
            d4txt1.text = "1"
        } else {
            d4txt1.text = "0"
        }
        val rand = Random().nextInt(4) + 1
        d4result.text = rand.toString()
    }

score -2 · Accepted Answer · answered May 13 '20 at 00:49

Java is tricky about that. The == operator compares the two object pointers, not their values. It's fine for integers and floats but almost never useful for strings.

Instead use the .equals() method or the .equalsIgnoreCase() method:

if (d4result.text.toString().equalsIgnoreCase("1")) { ...

Java If Else Text Based on Other Text

2 Answers2