using gcc and getting core dumped

Asked May 20 '20 at 14:14

Active May 20 '20 at 14:14

Viewed 26 times

hi i was trying to use this function to take out palindromes and make a new string with them but i get core dumped

i don't see any problem with code really it is complicated because i use so many parameters but i don't think that will make it wrong what do you think?

the result should be "noon i 313 a kayak"

char* Palindroms(char* str){
        int size = strlen(str);
        char *wordptr;
       char *revword;
       char *stringptr = malloc(size+1);
        for(int i = 0;i < size;i++){
             int j = 0;
             int k = 0;
            while(*str != ' '){
                wordptr[j] = *str++;
                i++;
            }
            while(j != 0){
                revword[k] = wordptr[j];
                j--;
                k++;
                }
                if(revword = wordptr)
                strcpy(stringptr + k,revword);
            }
            return stringptr;
        }

int main(){
    char string1[] = "yesterday noon i paid 313 shekels for a new kayak";
    char *string3 = Palindroms(string1);
    printf("%s", string3);

    return 0;

asked May 20 '20 at 14:14

Adham Jab

2

Did not look too deep, but this does not look right: `if(revword = wordptr)` – Eugene Sh. May 20 '20 at 14:17
1

`revword = wordptr`? Really? – MrProgrammer May 20 '20 at 14:18
1

Single step through the code with a debugger and see where it crashes. – Lundin May 20 '20 at 14:18
so how can i check if two words match? – Adham Jab May 20 '20 at 14:18
1

You never initialized revword and wordptr – m0hithreddy May 20 '20 at 14:18
= is assignment, == is comparison – RetardedHorse May 20 '20 at 14:19
1

First of all `=` is an assignment operator. Comparison is `==`. Second, strings cannot be compared this way, there is `strcmp` function for that. – Eugene Sh. May 20 '20 at 14:19
@AdhamJab Check the duplicate link I provided on top of your question. You have to use the strcmp function. – Lundin May 20 '20 at 14:20
wow didn't really see that i put single = that's embarrassing – Adham Jab May 20 '20 at 14:20
`while( j != 0 )`, `j` is always `0` – dvhh May 20 '20 at 14:21

using gcc and getting core dumped

0 Answers0