the Objective of this program is supposed to be printing cube

Question

cube of Randomly generated values which is not happeneing if I return the value from the main function.If I don't return it in the main function and print it in the user defined function then it is working properly. Where I have used pointers its mandatory.

#include<iostream>
#include<ctime>
using namespace std;



int* cube(int* ar)
{
    int re[50];
    for (int i = 0; i < 50; i++)
    {
        re[i] = *(ar + i) * *(ar + i)* *(ar + i);

    }
    return re;
}


int main()
{
    srand(time(NULL));
    int ar[50],
        cub[50];
    for (int i = 0; i < 50; i++)
    {
        ar[i] = (rand() % (99 - 50)) + 50;

    }
    int *ptr;
    cout << "Sr.#\tValue\tCube\n";
    ptr = cube(ar);  // this receives the value being returned from the function
    for (int i = 0; i < 50; i++)
    {
        cout << i << '\t' << ar[i] << '\t' << *(ptr + i) << endl;
    }
    return 0;
}

What is your question? Clarify the problem and include any error message or issue you're facing. — Omid, Jun 02 '20 at 04:36

score 1 · Answer 1 · answered Jun 02 '20 at 04:49

1

It is a bad idea to return pointers or references to local variables. replace

int re[50];

with

int* re=new int[50];

answered Jun 02 '20 at 04:49

Hikmat Farhat

552
3
9

Use `std::vector` to avoid direct allocations. – tadman Jun 02 '20 at 04:55
It is working bruh.. can U explain what it is? – user_not_dead Jun 02 '20 at 05:18
which part you want explained? please be more specific – Hikmat Farhat Jun 02 '20 at 05:49
The line u told me to add. I never used new int .. what is it? – user_not_dead Jun 02 '20 at 17:50
new allocates memory for an object and returns the address. So new int[50] allocates memory for 50 integers and the returns the address of the first one. – Hikmat Farhat Jun 03 '20 at 01:28

the Objective of this program is supposed to be printing cube

1 Answers1