1

I am using gmock to mock an underlying library while I am testing my wrapper for it. I notice that gmock requires the mock object to be predefined. What I want is to pass a pointer to the mock object. It doesn't work if the object is dynamically created which is needed to test error handling.

Refer : gmock/google-mock issues warning and fails the test with mocking exceptions Code:

test/mock_turtle_test.cc

#include "mock_turtle.h"
#include "../painter.h"
#include <gtest/gtest.h>

using  ::testing::_;
using  ::testing::AtLeast;
using  ::testing::Return;
ACTION(MyException)
{
        throw(error_k());
}
TEST(PainterTest, CanDrawSomething) {
  Painter painter;
  EXPECT_CALL(*(painter.getTurtle()), PenDown())
      .Times(AtLeast(1))
      .WillOnce(MyException())
      .WillRepeatedly(Return(5));
  EXPECT_TRUE(painter.DrawCircle(0, 0, 10));
}

int main(int argc, char **argv) {
        testing::InitGoogleTest(&argc, argv);
        return RUN_ALL_TESTS();
}

inc/mock_turtle.h

#pragma once
#include <cstdlib>
#include "turtle.h"
#include <gmock/gmock.h>

class Turtle : public FakeTurtle{
 public:
  using FakeTurtle::FakeTurtle;
  MOCK_METHOD((void), PenUp, ());
  MOCK_METHOD((int), PenDown, ());
  MOCK_METHOD((void), Forward, (int distance));
  MOCK_METHOD((void), Turn, (int degrees));
  MOCK_METHOD((void), GoTo, (int x, int y));
  MOCK_METHOD((int), GetX, ());
  MOCK_METHOD((int), GetY, ());
};

inc/turtle.h

#pragma once

class FakeTurtle {

public:
  virtual ~FakeTurtle() {}
  virtual void PenUp() {};
  virtual int PenDown() {};
  virtual void Forward(int distance) {};
  virtual void Turn(int degrees) {};
  virtual void GoTo(int x, int y) {};
  virtual int GetX() const {};
  virtual int GetY() const {};

};

painter.h

#pragma once
#include "turtle.h"
#include <cerrno>

class error_k
{
public:
    error_k() : errnum(EAGAIN){}
    int num() const
    {
        return errnum;
    }
private:
    int errnum;
};

class Painter
{
        Turtle* turtle;
public:
        Painter() : turtle(new Turtle){}
        //Painter(){}
    Turtle** getTurtle(){
        return &turtle;
    }
        bool DrawCircle(int, int, int){
        int rep = 10;
        int ret = 0;
        delete turtle;
        turtle = new Turtle;
        do{
            try{
                std::cout << "calling PenDown() : rep = " <<
                    rep << " , ret = " << ret << std::endl;
                        ret = turtle->PenDown();
                if(ret > 0)
                    return true;
            }catch(error_k err )
            {
                std::cout << "Caught Exception (" <<
                    err.num() << "): rep = " <<
                    rep << " , ret = " << ret << std::endl;

                delete turtle;
                turtle = new Turtle();
            }
        }while(rep-- > 0 && ret == 0); 
                return false;
        }
    ~Painter(){
        delete turtle;
    }
};

CmakeLists.txt

cmake_minimum_required(VERSION 2.6)

# Locate GTest
find_package(GTest REQUIRED)
find_package(PkgConfig)
message(STATUS "gtest found: " ${GTEST_FOUND})
pkg_check_modules(GMOCK "gmock" REQUIRED)
message(STATUS "gmock found: " ${GMOCK_FOUND})

include_directories(${GTEST_INCLUDE_DIRS})

# Link runTests with what we want to test and the GTest and pthread library
add_executable(runTests test/mock_turtle_test.cc)
target_link_libraries(runTests ${GTEST_LIBRARIES} ${GMOCK_LIBRARIES} gmock gmock_main gtest gtest_main)
target_include_directories(runTests SYSTEM PRIVATE inc)
add_test(NAME runTests COMMAND runTests)
enable_testing()

Output:

$ make ; ./runTests 
Scanning dependencies of target runTests
[ 50%] Building CXX object CMakeFiles/runTests.dir/test/mock_turtle_test.cc.o
[100%] Linking CXX executable runTests
[100%] Built target runTests
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from PainterTest
[ RUN      ] PainterTest.CanDrawSomething
/home/preetam/Desktop/gmock/cpp_mock_ptr/test/mock_turtle_test.cc:16: Failure
Actual function call count doesn't match EXPECT_CALL(**tt, PenDown())...
         Expected: to be called at least once
           Actual: never called - unsatisfied and active
calling PenDown() : rep = 10 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 9 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 8 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 7 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 6 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 5 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 4 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 3 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 2 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 1 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
calling PenDown() : rep = 0 , ret = 0

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: PenDown()
          Returns: 0
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#knowing-when-to-expect for details.
/home/preetam/Desktop/gmock/cpp_mock_ptr/test/mock_turtle_test.cc:20: Failure
Value of: painter.DrawCircle(0, 0, 10)
  Actual: false
Expected: true
[  FAILED  ] PainterTest.CanDrawSomething (0 ms)
[----------] 1 test from PainterTest (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (1 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] PainterTest.CanDrawSomething

 1 FAILED TEST
Quarra
  • 2,527
  • 1
  • 19
  • 27
preetam
  • 1,451
  • 1
  • 17
  • 43
  • " I notice that gmock requires the mock object to be predefined. What I want is to pass a pointer to the mock object." Yet the code is not about that? Also, if it requires something, it may be a good idea to respect that, because it's the likely reason for your exception. – Jaffa Jun 11 '20 at 07:15
  • I would like to overcome the limitation and work with a runtime created object. The issue is with the matchers. I wonder how to get over it. – preetam Jun 11 '20 at 08:33
  • I still don't see anything related to that in your code. Please post a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) – Jaffa Jun 11 '20 at 08:46
  • There, I added the full code here. I originally gave link to another question that had the full code. – preetam Jun 11 '20 at 17:16
  • It's still not a minimal reproducible example, and you still have a lot of code which doesn't make sense, like painter.h referring to `Turtle` but it should only know about `FakeTurtle`, as per your code. – Jaffa Jun 12 '20 at 05:45

1 Answers1

0

Can you create a mock object of type FakeTurtle and use dependency injection technique (see Dependency injection with unique_ptr to mock if Painter needs to be the owner of the injected object; but first try to refactor your code in a way that Painter accepts reference to Turtle, i.e. Turtle& in its constructor - it is way easier).

GoogleMock framework requires that a mock object is created and all the expectations are set on this very object (not some other object).

Side note: I'd make Turtle a pure-virtual interface.

Quarra
  • 2,527
  • 1
  • 19
  • 27