NullReferenceException when using custom get/set

Question

I wrote a custom getter/setter for a property in a ViewModel that is set in the model. But I get a NullReferenceException at the first if-statement:

System.NullReferenceException: 'Object reference not set to an instance of an object.'

public class PDILogisticsViewModel
{
    private string _PDIComment;

    public string PDIComment {
     set {
      this._PDIComment = value;
     }
     get {
      if (_PDIComment.Equals("1"))
       return "Technischer Defekt";
      else if (_PDIComment.Equals("2"))
       return "OK";
      else
       return "Sonstiges";
     }

} }

When I use this code, everything works fine:

public string PDIComment { get; set; }

I also tried to add a null-check to return an empty string when _PDIComment is null but when I do that, the program crashes:

The program '[17728] iisexpress.exe' has exited with code -1073741819 (0xc0000005) 'Access violation'.

 public string _PDIComment;
        public string PDIComment 
        {
            set
            {
                _PDIComment = value;
            }
            get
            {
                if (_PDIComment == null)
                    return "";
                else if (_PDIComment == "1")
                    return "Technischer Defekt";
                else if (_PDIComment == "2")
                    return "OK";
                else
                    return "Sonstiges";
            }
        }

Any idea what the problem could be here?

Ugh, the error was on my side. I mixed up some variable names but still, adding the null-check basically solved this problem. — d00d, Jun 12 '20 at 07:15

score 1 · Answer 1 · answered Jun 12 '20 at 06:50

1

Use == not .equals

This is C# not Java. You cannot use a . after a value that is null.

answered Jun 12 '20 at 06:50

JoelFan

37,465
35
132
205

NullReferenceException when using custom get/set

1 Answers1