Better way of writing this

Question

if (isset($row['product_limit'])){
    if ($row['product_limit'] != 0){
        echo $row['product_limit'];
    } else {
        echo $text_infinite;    
    }
} else {
    echo $text_infinite;
}

Is there a better way of writing this???

EDIT:

though I used the @Radu code but here is the version i used

echo (isset($row['product_limit']) 
&& $row['product_limit'] != 0) ? $row['product_limit'] : 'unlimited' ;

Not expected this many methods :) Thanks All

the ternary operator is good if the code is short, otherwise it will become hard to read... If you prefer using 2 conditions (`isset` and `!= 0`) instead of one (`empty`), then you should consider using `if`/`else` instead of `?:`. — rid, Jun 04 '11 at 14:30
Also take a look at this question to find out about the difference between `empty()` and `isset()`: http://stackoverflow.com/questions/4559925/why-check-both-isset-and-empty — rid, Jun 04 '11 at 14:50

rid · Accepted Answer · 2011-06-04T14:15:53.490

13

How about this?

echo empty($row['product_limit']) ? $text_infinite : $row['product_limit'];

Take a look at the documentation for empty() and the ternary conditional operator.

edited Jun 04 '11 at 14:15

answered Jun 04 '11 at 14:08

rid

61,078
31
152
193

score 1 · Answer 2 · answered Jun 04 '11 at 14:09

1

if (isset($row['product_limit']) && $row['product_limit'] != 0){
     echo $row['product_limit'];
} else {
    echo $text_infinite;    
}

answered Jun 04 '11 at 14:09

Philipp

1,903
2
24
33

@sterefrog why what is wrong with empty() ??? – jimy Jun 04 '11 at 14:19

score 0 · Answer 3 · answered Jun 04 '11 at 14:09

if (!empty($row['product_limit'])){
    echo $row['product_limit'];
} else {
    echo $text_infinite;    
}

As php.net says, the following things are considered to be empty:

"" (an empty string)
0 (0 as an integer)

and so on..

score 0 · Answer 4 · answered Jun 04 '11 at 14:15

Maybe you can try some EXME method.

    if (isset($row['product_limit']))
    {
        $msg = $row['product_limit'];
    }
    else
    {
        $msg = "";
    }

Then you just need to output the code somewhere else by calling the echo of the $msg variable.

Better way of writing this

4 Answers4