When running code, c++ terminates the process

Question

I'm trying to write code for the game tictactoe, i'm almost finished, I haven't yet written the part of the code that ends the game. My only problem is that c++ stops running, "Process terminated with status 0". Other than that the code runs fine. In fact it works perfectly until it gets terminated, can anyone help me? Indentation messed up the graphical part of the board function so don't mind that. The function board() creates a 3 by 3 grid labelled 1-9, the function game() replaces each number with an O or X depending on which number the plpayer picks, all done by the switch and while statmements. Here is my code, thank you.

using namespace std;
string a = "1";
string b = "2";
string c = "3";
string d = "4";
string e = "5";
string f = "6";
string g = "7";
string h = "8";
string i = "9";
string s1;
string s2;
string o = "O";
string x = "X";
string k = "Tic-Tac-Toe\n";
void ClearScreen() {
  cout << string(100, '\n');
}
void board() {
  std::cout << "             " << k;
  std::cout << "           |           |           \n";
  std::cout << "     " << a << "     |     " << b << "     |     " << c << "     \
  n ";
  std::cout << "___________|___________|___________\n";
  std::cout << "           |           |           \n";
  std::cout << "     " << d << "     |     " << e << "     |    " << f << "     \
  n ";
  std::cout << "___________|___________|___________\n";
  std::cout << "           |           |           \n";
  std::cout << "     " << g << "     |     " << h << "     |     " << i << "     \
  n ";
  std::cout << "           |           |           \n";
  std::cout << "      Player 1:O, Player 2:X\n";
}
void game() {
  board();
  int z = 1;
  while (z <= 9 && z % 2 == 1) {
    std::cin >> s1;
    int n1 = stoi(s1);
    switch (n1) {
    case 1:
      a = o;
      z++;
      break;
    case 2:
      b = o;
      z++;
      break;
    case 3:
      c = o;
      z++;
      break;
    case 4:
      d = o;
      z++;
      break;
    case 5:
      e = o;
      z++;
      break;
    case 6:
      f = o;
      z++;
      break;
    case 7:
      g = o;
      z++;
      break;
    case 8:
      h = o;
      z++;
      break;
    case 9:
      i = o;
      z++;
      break;
    }
    board();

  }
  while (z <= 9 && z % 2 == 0) {
    std::cin >> s2;
    int n2 = stoi(s2);
    switch (n2) {
    case 1:
      a = x;
      z++;
      break;
    case 2:
      b = x;
      z++;
      break;
    case 3:
      c = x;
      z++;
      break;
    case 4:
      d = x;
      z++;
      break;
    case 5:
      e = x;
      z++;
      break;
    case 6:
      f = x;
      z++;
      break;
    case 7:
      g = x;
      z++;
      break;
    case 8:
      h = x;
      z++;
      break;
    case 9:
      i = x;
      z++;
      break;
    }
    board();
  }
}

int main() {
  game();

}

Answer 1

The problem is that you're executing one round for player O. One round for player X. And then exiting the game function. You never tell your code to loop back up to the turn for player O.

In your code:

void game() {
  board();
  int z = 1;
  while (z <= 9 && z % 2 == 1) {
    std::cin >> s1;
    int n1 = stoi(s1);
    switch (n1) {
    case 1:
      a = o;
      z++;
      break;
    ...
    }
    board();

  }
  while (z <= 9 && z % 2 == 0) {
    std::cin >> s2;
    int n2 = stoi(s2);
    switch (n2) {
    case 1:
      a = x;
      z++;
      break;
    ...
    }
    board();
  }
}

You enter the first while loop (player O) while z==1, and both parts of the loop conditional are true. Then you make a move, increment z by 1, and the second part of the loop conditional (z % 2 == 1) is no longer true. That loop ends. You move onto the next loop (player X) and do something similar, then exit entirely.

It looks like you're using z to keep track of which turn it is? In that case, I suggest having one OUTER loop to keep track of the turns, two INNER SWITCHES to handle each player's turn. You can clean it up and it will look something like this:

void game() {
  board();
  // executes 9 rounds of the game
  // each player gets one turn per round
  for (int z = 0; z < 9; ++z)
  {
    // player O
    std::cin >> s;
    int n = stoi(s);
    switch (n)
    {
      case 1: a = o; break;
      case 2: b = o; break;
      case 3: c = o; break;
      ...
    }
    board();

    // player X
    std::cin >> s;
    int n = stoi(s);
    switch (n)
    {
      case 1: a = x; break;
      case 2: b = x; break;
      case 3: c = x; break;
      ...
    }
    board();
  }
}

There are other changes I would make to encapsulate code into functions and reuse code and increase readability, but I don't want to completely rewrite your code and make it unrecognizable to you. Baby steps. Also, any changes I make would just be, like, my opinion. And you know what they say about opinions.