How do you put the text from a string into code?

Question

I am trying to make a one line JavaScript code software and right now it looks perfectly fine... until you hit the run button. Instead of running the code (like it's supposed to), it does absolutely nothing. So yeah, you can see the problem I am having with this.
Here's my HTML (in case you want to look over it):

<!DOCTYPE html>
<html>
  <body>
    <div class="default">
      <input type="text" id="codeInput" placeholder="document.write(`Hello, world!`)" value="document.write(`Hello, world!`)" class="code">
      <br/>
      <button onclick="convertString()">Run</button>
    </div>
    <div class="default">
      <script type="text/javascript" id="code">
        document.write(`Hello, world!`)
      </script>
    </div>
  </body>
</html>

Here's my JavaScript:

function convertString () {
  let code = document.getElementById("codeInput").value
  document.getElementById("code").innerHTML = code
}

And here's my CSS (not sure why I put this in here, but you can look over it if you want to):

.code {
  color: #162;
}
.default {
  display: block;
  margin: 8px;
}

So uhh... I'm having trouble. can you please help me?
<h1>Thank you!</h1>
Edit 1 (4 Jul 2020): No, this is not the same as stackoverflow.com/questions/1197575. S/he was trying to use onload="" to do a <script></script> inside the onload="". I am trying to call a function with a separate run function in my JavaScript and using a separate <script></script> tag.

Where are you including your JavaScript code from your HTML? Do you see any errors in the console? — D. Pardal, Jul 03 '20 at 16:17
Are any errors thrown in your browser dev tools console? Always check there — charlietfl, Jul 03 '20 at 16:20
Did you link the JS file containing `convertString` to your HTML file? — Mubaraq Wahab, Jul 03 '20 at 16:21
The problem that you are having is you are trying to run javascript by simply using javascript to place it into script tags like it is a string. There is a very frowned upon and potentially dangerous solution for what you are trying to do and that is use `eval` to evaluate and run the code in the box `eval(code)`. Are you the only one that will be entering in the javascript for this? — imvain2, Jul 03 '20 at 16:24
Does this answer your question? [Can scripts be inserted with innerHTML?](https://stackoverflow.com/questions/1197575/can-scripts-be-inserted-with-innerhtml) — Mubaraq Wahab, Jul 03 '20 at 16:29
@imvain2 +, when i tried to use eval(), the thing LITERALLY just said, goodbye!. — Coarse Rosinflower, Jul 04 '20 at 13:42

score 2 · Answer 1 · answered Jul 03 '20 at 16:19

2

In your html code, you're referring to a function (convertString()) which is defined outside the html page, in a separate file. You need to reference the JS file from your HTML page

<script src="path/to/script.js"/>

It is usually better to include JS files at the bottom of the page, in order for the browser to download every other file and start its JS engine at last

answered Jul 03 '20 at 16:19

luco5826

404
3
6

@COArSeD1RTxxx do you have a separate javascript file? Where is your `convertString()` function written? The code I suggested doesn't work because you need to change the path to the source js file – luco5826 Jul 04 '20 at 16:03
*sigh*. Yes, I do have a searate javascript file – Coarse Rosinflower Jul 16 '20 at 14:31

score 2 · Answer 2 · answered Jul 03 '20 at 16:26

2

function convertString() {
  let code = document.getElementById("codeInput").value
  document.getElementById("code").innerHTML = code
}

.code {
  color: #162;
}

.default {
  display: block;
  margin: 8px;
}

<body>
  <div class="default">
    <input type="text" id="codeInput" placeholder="document.write(`Hello, world!`)" value="document.write(`Hello, world!`)" class="code">
    <br/>
    <button onclick="convertString()">Run</button>
  </div>
  <div class="default">
    <div id="code"></div>
  </div>

it is not good to called script tag and render something there sometimes it won't work if it is not the JavaScript code

answered Jul 03 '20 at 16:26

Umutambyi Gad

4,082
3
18
39

what you meant m8 is that browser – Umutambyi Gad Jul 04 '20 at 12:51
no... thats not what i want ***AT ALL***. I am not trying to write a thing. I am trying to make a coding software – Coarse Rosinflower Jul 04 '20 at 13:02
however, you did do a gud – Coarse Rosinflower Jul 04 '20 at 13:03
how do u do dat – Coarse Rosinflower Jul 04 '20 at 13:57
It takes more effort to answer the question so it's good idea to mark it as accepted if you do – Umutambyi Gad Jul 25 '20 at 13:13

How do you put the text from a string into code?

2 Answers2