OUTPUT ERROR,The problem is to find the sum 5000 digit number cpp

Question

This is the code(cpp)

    #include <iostream>
    #include <string>
    #include <numeric>//to import the accumulate function
    #include <vector>
    #include <algorithm>

    using namespace std;
    int main(){
    vector<long long> vi;
     string s; //this contains the long number its better not to type here
    int k=0,sum=0;
     for(int i=0;i<s.length();i++){
      k=(int)s[i]-(int)'0';
     cout<<k<<endl;
       vi.push_back(k);
 
      }
      for(int i:vi){
        cout<<i<<endl;
      }
         cout<<accumulate(vi.begin(),vi.end(),0);

    
        }

whatever i do i get the answer 22660 i tried using without accumulate still 22660 ,i dont know why this happens

It's kind of hard to tell why you get 22660 without knowing what the number is. — john, Jul 03 '20 at 18:29
Hint: read the number as a string. Access the digits like: `int digit_value = number_as_string[x] - '0';` — Thomas Matthews, Jul 03 '20 at 18:31
@ThomasMatthews That's what he is doing or am I missing something? — john, Jul 03 '20 at 18:32
Anyway the posted code looks OK to me, the error is probably in the part that's been left out. — john, Jul 03 '20 at 18:33
Why are you placing the digit into a `vector` after isolating it? Why not add the digit to a sum variable directly? — Thomas Matthews, Jul 03 '20 at 18:35
22660 is actually a not implausable result from summing 5000 digits, what makes you think it's wrong? — john, Jul 03 '20 at 18:36
@john the answer is 567.......... its a very large number this is a question from project euler question number 13 — Vict_r prin_e, Jul 03 '20 at 18:39
@JesperJuhl i was not shouting i forgot to turn off the caps sorry — Vict_r prin_e, Jul 03 '20 at 18:40
You say you know what the input string is, and what the expected result should be. Why don't you share that with us? — cigien, Jul 03 '20 at 18:41
@Vict_rprin_e Read what you wrote before posting it, please. I shouldn't have to say that, it should be an obvious thing to do. — Jesper Juhl, Jul 03 '20 at 18:42
Let's look at the worst case. The maximum value for a digit is 9. The maximum quantity of digits is 5000. The maximum sum is 9 + 9 + 9 ..., which is the same as 5000*9. and 5000*9 == 45000. This is clearly less than the maximum range of an int. — Thomas Matthews, Jul 03 '20 at 18:42
@cigien the input is very large it contains 100 lines of 50 digits — Vict_r prin_e, Jul 03 '20 at 18:43
Please edit your post with description of the problem. I searched for "5000 digit sum" and came up with Fibonacci numbers and prime numbers. — Thomas Matthews, Jul 03 '20 at 18:47
@Vict_rprin_e If the real number is spread over 100 lines it is possible that you are incorporating some non-digits (like whitespace or line endings) into your number? — john, Jul 03 '20 at 18:48
You may have a [misunderstanding of the problem](https://stackoverflow.com/questions/20124928/project-euler-13-understandning-python). If this is the same problem, you'll want to sum numbers that are 50 digits in length. There are 100 of these numbers to sum. — Thomas Matthews, Jul 03 '20 at 18:51

score 0 · Accepted Answer · answered Jul 03 '20 at 18:39

I don't understand why you are using std::vector. You could calculate the sum without using the vector:

int k=0,sum=0;
for(int i=0;i<s.length();i++)
{
    k = s[i]-'0';
    sum += k;
}

Note: if you are a little paranoid of the sum value fitting into an integer, you can use an unsigned integer since digits can't be negative.

OUTPUT ERROR,The problem is to find the sum 5000 digit number cpp

1 Answers1