How to edit a curried/arrow function to include a regex?

Question

I'm using Nick Grealy's amazingly terse table sorter (Sorting HTML table with JavaScript), but it doesn't properly sort columns that are dollar amounts {$199, $23, $46} or columns that are percentages {10%, 3%, 5%}; the largest values are improperly sorted to the top because the algo is doing a text sort, because the values contain non-numeric chars (% and $).

I understand the general idea of fixing that: strip out any $ or % signs, and then sort on the result (which will be numeric). My problem is that Grealy's code is way over my head and I don't see how to edit it. I tried this:

const comparer = (idx, asc) => (a, b) => ((v1, v2) => 
    v1=v1.replace(/[$%]/,''); // << My addition
    v2=v2.replace(/[$%]/,''); // << My addition
    v1 !== '' && v2 !== '' && !isNaN(v1) && !isNaN(v2) ? v1 - v2 : v1.toString().localeCompare(v2)
    )(getCellValue(asc ? a : b, idx), getCellValue(asc ? b : a, idx));

But that gives a syntax error. I spent some time studying arrow functions and curried functions but it's pretty confusing even for simple examples, and Grealy's code is more complex than that (e.g., the extra ( before (v1,v2) that doesn't get resolved until several lines later. How can I modify the code to sort $ and % values properly?

TheWuif · Accepted Answer · 2020-07-20T07:20:01.407

1

If you write multiline functions, you need to use braces.

const comparer = (idx, asc) => (a, b) => ((v1, v2) => {
  v1 = v1.replace(/[$%]/,'');
  v2 = v2.replace(/[$%]/,'');
  return v1 !== '' && v2 !== '' && !isNaN(v1) && !isNaN(v2) ? v1 - v2 : v1.toString().localeCompare(v2)
})(getCellValue(asc ? a : b, idx), getCellValue(asc ? b : a, idx));

*updated code

edited Jul 20 '20 at 07:20

answered Jul 19 '20 at 16:12

TheWuif

988
6
11

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/block – numbers1311407 Jul 19 '20 at 16:15
TheWulf, I'm afraid I still get a syntax error with your code. – Michael Bluejay Jul 19 '20 at 18:19
the code you sad you haven't touched is invalid. i don't know what you wanted to achieve here. – TheWuif Jul 20 '20 at 07:15
i updated the code in the answer. i think this should work – TheWuif Jul 20 '20 at 07:19

How to edit a curried/arrow function to include a regex?

1 Answers1