77

Not able to add comments on Gerrit. It rather gets added as Draft. What am I doing wrong? Others in my team are able to add comments though.

Gunanaresh
  • 959
  • 1
  • 9
  • 20

5 Answers5

94

Comments are published when you make them part of a review. Post a review and the comments will be published with it. (You can score the commit as +0 if you don't have any opinion either way.)

  • 66
    Who could know? Gerrit has one of the worst UIs I've seen (especially "feel" part, "look" is merely OK). And that tool creeps thru the industry (press releases would call that "adoption"). Thanks Google! – pfalcon Sep 24 '13 at 15:12
  • 1
    How do you "post" a review or "publish" the comments? I created my first review and added comments to explain my changes, and they all remained as drafts. Unfortunately I refreshed the page and all the drafts were lost. +1 about the comment about bad UI! I much prefer Code Collaborator. – jfritz42 Oct 30 '13 at 19:59
  • 2
    Go back up to the main review from any file you're looking at (hotkey: `u`) and click the "Review" button, which should be the first one under the patchset. –  Oct 30 '13 at 23:19
  • 11
    @jfritz42 Click the "Reply..." button in the header of the change. – thSoft May 04 '15 at 10:42
  • 3
    duskwuff's comment is outdated or at least not applicable to the version of Gerrit I'm using. thSoft's does work. – Confusion May 06 '15 at 09:38
  • 2
    You need to click reply in the main header after posting your comment. (hotkey: `u` to get to the main review), this will then let you publish the draft. – Zach Alberico Jul 28 '17 at 16:54
  • @pfalcon I've never found a Google product with a good UI. Even the simplest thing like the google.com home page has problems. And it gets worse from there. – Snowcrash Dec 22 '20 at 17:28
19

Click on the Reply button in the header. Then Post it.

Darshan B
  • 209
  • 2
  • 2
  • 3
    As this is a popular question, I think it would be relevant for you to review [how to write a good answer](http://stackoverflow.com/help/how-to-answer). Please add some references and broaden your explanation. – Quintin Balsdon Jan 20 '17 at 08:26
  • 1
    On the other hand, your answer is fully correct. And I have ran into that myself; so I see some merit. Still, consider improving it! – GhostCat Jan 20 '17 at 08:51
  • 1
    `Reply` button to submit a review... so unintuitive. – wisbucky Oct 04 '17 at 00:05
  • @wisbucky For sure. This is why I hate Gerrit but I have no choice to use it where I'm currently employed. – rayryeng Nov 15 '17 at 18:01
9

For those who has happened to be stumbled (like me) with how to post comments for work-in-progress (WIP) review without starting review (e.g. leaving in work-in-progress state), Gerrit version 2.16. Here's counter-intuitive answer:

  • Press "START REVIEW" button - don't afraid, it will not start review immediately (at least on above mentioned version)
  • Press "SAVE" (greyish! not quite noticeable) in opened window in left bottom corner

UPDATE

In newer version I got 3.2.3 - it's been improved, the button is not greyish and looks normal and in the right bottom corner together with other buttons: | CANCEL | SAVE | SEND AND START REVIEW |

pmod
  • 10,450
  • 1
  • 37
  • 50
7

And since I am not able to add a comment :

When you want to add comments to a specific revision(Patch Set), switch to that revision and then click on reply. This "Patch Sets" option is found on the upper right corner next to "Download".

screenshot : Switch to a Patch Set

Had to learn the Hard Way today. :-/

Caleb Kleveter
  • 11,170
  • 8
  • 62
  • 92
daredadevil
  • 317
  • 1
  • 6
  • 19
0

At least on Qt's Gerrit system:

After saving the comment draft, yse the keyboard shortcut 'r' to publish a "review" which publishes the comment.

Harald Nordgren
  • 11,693
  • 6
  • 41
  • 65