72

I have: 

string filename: 
ifstream file(filename);

The compilers complains about no match between ifstream file and a string. Do I need to convert filename to something?

Here's the error:

error: no matching function for call to ‘std::basic_ifstream<char, std::char_traits<char> >::basic_ifstream(std::string&)’
/usr/include/c++/4.4/fstream:454: note: candidates are: std::basic_ifstream<_CharT, _Traits>::basic_ifstream(const char*, std::_Ios_Openmode) [with _CharT = char, _Traits = std::char_traits<char>]
James Mertz
  • 8,459
  • 11
  • 60
  • 87
Mark
  • 8,408
  • 15
  • 57
  • 81

3 Answers3

144

Change

ifstream file(filename);

to

ifstream file(filename.c_str());

Because the constructor for an ifstream takes a const char*, not a string pre-C++11.

Seth Carnegie
  • 73,875
  • 22
  • 181
  • 249
11

The ifstream constructor expects a const char*, so you need to do ifstream file(filename.c_str()); to make it work.

Alexander Gessler
  • 45,603
  • 7
  • 82
  • 122
1

in c++-11 it can also be an std::string. So (installing c++-11 and) changing the dialect of you project to c++-11 could also fix the problem.

evi v
  • 11
  • 5
  • 1
    while your answer is correct, it is already present in the accepted answer, although not so clearly: `not a string pre-C++11.` – Chris Maes Jan 06 '16 at 08:06