Android app has stopped and attempt to invoke virtual method on a null object reference

Question

When I run my android app, it crashes and says that Android app has stopped. It also gives this error message:

java.lang.NullPointerException: Attempt to invoke virtual method 'com.esimerkki.doodl2.DoodleView com.esimerkki.doodl2.FirstFragment.getDoodleView()' on a null object reference

What is wrong with this? Is the reference really null? How could I make this work? I thought these original settings in doodleView have start values?

Here is the code of doodleView class:

package com.esimerkki.doodl2;

import android.content.Context;
import android.view.View;

import android.graphics.Bitmap;
import android.graphics.Canvas;
import android.graphics.Color;
import android.graphics.Paint;
import android.graphics.Path;
import android.graphics.Point;
import android.provider.MediaStore;

import android.util.AttributeSet;
import android.view.Gravity;
import android.view.MotionEvent;
import android.widget.Toast;

import androidx.print.PrintHelper;

import java.util.HashMap;
import java.util.Map;

public class DoodleView extends View {

    public DoodleView(Context context, Paint paintScreen, Paint paintLine) {
        super( context );
        this.paintScreen = paintScreen;
        this.paintLine = paintLine;
    }

    private static final float TOUCH_TOLERANCE = 10;

    private Bitmap bitmap; // drawing area
    private Canvas bitmapCanvas; // 
    private final Paint paintScreen; // 
    private final Paint paintLine; // 

   
    private final Map<Integer, Path> pathMap = new HashMap<>();
    private final Map<Integer, Point> previousPointMap = new HashMap<>();


    public DoodleView(Context context, AttributeSet attrs) {
        super(context, attrs); // kutsutaan yliluokanalustajaa
        paintScreen = new Paint(); // bittikartan näyttämiseen ruudulla

      
        paintLine = new Paint();
        paintLine.setAntiAlias(true); 
        paintLine.setColor(Color.BLACK); 
        paintLine.setStyle(Paint.Style.STROKE); 
        paintLine.setStrokeWidth(5); 
        paintLine.setStrokeCap(Paint.Cap.ROUND); 
   
    @Override
    public void onSizeChanged(int w, int h, int OldW, int oldH) {
        bitmap = Bitmap.createBitmap(getWidth(), getHeight(),
                Bitmap.Config.ARGB_8888); 
        bitmapCanvas = new Canvas(bitmap);
        bitmap.eraseColor(Color.WHITE); 
    }

    
    public void clear() {
        pathMap.clear(); 
        previousPointMap.clear(); 
        bitmap.eraseColor(Color.WHITE); 
        invalidate(); 
    }

  
    public void setDrawingColor(int color) {
        paintLine.setColor(color);
    }

  
    public int getDrawingColor() {
        return paintLine.getColor();
    }

    public void setLineWidth(int width) {
        paintLine.setStrokeWidth(width);
    }

   
    public int getLineWidth() {
        return (int) paintLine.getStrokeWidth();
    }

    @Override
    protected void onDraw(Canvas canvas) {
       
        canvas.drawBitmap(bitmap, 0, 0, paintScreen);

        for (Integer key : pathMap.keySet())
            canvas.drawPath(pathMap.get(key), paintLine); // piirretään viiva
    }

    @Override
    public boolean onTouchEvent(MotionEvent event) {
        int action = event.getActionMasked(); // tapahtumatyyppi
        int actionIndex = event.getActionIndex(); // osoitin

        if (action == MotionEvent.ACTION_DOWN ||
                action == MotionEvent.ACTION_POINTER_DOWN) {
            touchStarted(event.getX(actionIndex), event.getY(actionIndex),
                    event.getPointerId(actionIndex));
        }
        else if (action == MotionEvent.ACTION_UP ||
                action == MotionEvent.ACTION_POINTER_UP) {
            touchEnded(event.getPointerId(actionIndex));
        }
        else {
            touchMoved(event);
        }

        invalidate(); 
        return true;
    }

   
    private void touchStarted(float x, float y, int lineID) {
        Path path; // tallennetaan tietyn id:n polku
        Point point; // tallennetaan polun viimeinen piste

       
        if (pathMap.containsKey(lineID)) {
            path = pathMap.get(lineID); 
            path.reset(); 
            point = previousPointMap.get(lineID); 
        }
        else {
            path = new Path();
            pathMap.put(lineID, path);
            point = new Point(); 
            previousPointMap.put(lineID, point); 
        }

        path.moveTo(x, y);
        point.x = (int) x;
        point.y = (int) y;
    }

    private void touchMoved(MotionEvent event) {
        
        for (int i = 0; i < event.getPointerCount(); i++) {
            // luetaan pointtein id ja indeksi
            int pointerID = event.getPointerId(i);
            int pointerIndex = event.findPointerIndex(pointerID);

         
            if (pathMap.containsKey(pointerID)) {
            
                float newX = event.getX(pointerIndex);
                float newY = event.getY(pointerIndex);

                Path path = pathMap.get(pointerID);
                Point point = previousPointMap.get(pointerID);
                // lasketaan kuinka kauas liikuttu
                float deltaX = Math.abs(newX - point.x);
                float deltaY = Math.abs(newY - point.y);

                if (deltaX >= TOUCH_TOLERANCE || deltaY >= TOUCH_TOLERANCE) {
            
                    path.quadTo(point.x, point.y, (newX + point.x) / 2,
                            (newY + point.y) / 2);

                 
                    point.x = (int) newX;
                    point.y = (int) newY;
                }
            }
        }
    }

    private void touchEnded(int lineID) {
        Path path = pathMap.get(lineID); 
        bitmapCanvas.drawPath(path, paintLine); 
        path.reset(); // tyhjennetään polku
    }

 
    public void saveImage() {
    
        final String name = "Doodlz" + System.currentTimeMillis() + ".jpg";

        String location = MediaStore.Images.Media.insertImage(
                getContext().getContentResolver(), bitmap, name,
                "Doodlz Drawing"
        );

        if (location != null) {
          
            Toast message = Toast.makeText(getContext(),
                    R.string.message_saved,
                    Toast.LENGTH_SHORT);
            message.setGravity(Gravity.CENTER, message.getXOffset() / 2,
                    message.getYOffset() / 2);
            message.show();
        }
        else {
          
            Toast message = Toast.makeText(getContext(),
                    R.string.message_error_saving, Toast.LENGTH_SHORT);
            message.setGravity(Gravity.CENTER, message.getXOffset() / 2,
                    message.getYOffset() / 2);
            message.show();
        }
    }

    public void printImage() {
        if (PrintHelper.systemSupportsPrint()) {
          
            PrintHelper printHelper = new PrintHelper(getContext());

            printHelper.setScaleMode(printHelper.SCALE_MODE_FIT);
            printHelper.printBitmap("Doodlz Imate", bitmap);
        }
        else {
         
            Toast message = Toast.makeText(getContext(),
                    R.string.message_error_printing, Toast.LENGTH_SHORT);
            message.setGravity(Gravity.CENTER, message.getXOffset() / 2,
                    message.getYOffset() / 2);
            message.show();
        }
    }


}

And here is the code of a LineWidthFragment class:

package com.esimerkki.doodl2;

import android.app.Activity;
import android.app.AlertDialog;
import android.app.Dialog;
import android.content.Context;
import android.content.DialogInterface;
import android.graphics.Bitmap;
import android.graphics.Canvas;
import android.graphics.Paint;
import android.os.Bundle;
//import android.support.v4.app.DialogFragment;
import android.view.View;
import android.widget.ImageView;
import android.widget.SeekBar;
import android.widget.SeekBar.OnSeekBarChangeListener;

import androidx.fragment.app.DialogFragment;

public class LineWidthFragment extends DialogFragment {

    private ImageView widthImageView;

    @Override
    public Dialog onCreateDialog(Bundle bundle) {
        
        AlertDialog.Builder builder =
                new AlertDialog.Builder(getActivity());
        View lineWidthDialogView =
                getActivity().getLayoutInflater().inflate(
                        R.layout.fragment_line_width, null);
        builder.setView(lineWidthDialogView); // lisätään GUI dialogiin

      
        builder.setTitle(R.string.title_line_width_dialog);

     
        widthImageView = (ImageView) lineWidthDialogView.findViewById(
                R.id.widthImageView);

     
        final DoodleView doodleView = getDoodleFragment().getDoodleView();
    
        final SeekBar widthSeekBar = (SeekBar)
                lineWidthDialogView.findViewById(R.id.widthSeekBar);
        widthSeekBar.setOnSeekBarChangeListener(lineWidthChanged);
        widthSeekBar.setProgress(doodleView.getLineWidth());


        builder.setPositiveButton(R.string.button_set_line_width,
                new DialogInterface.OnClickListener() {
                    @Override
                    public void onClick(DialogInterface dialog, int id) {
                        doodleView.setLineWidth(widthSeekBar.getProgress());
                    }
                }
        );
        return builder.create();
    }

    private FirstFragment getDoodleFragment() {
        return (FirstFragment) getChildFragmentManager().findFragmentById(
                R.id.doodleFragment);
    }


    @Override
    public void onAttach(Context context) {
        super.onAttach(context);
        FirstFragment fragment = getDoodleFragment();

        if (fragment != null)
            fragment.setDialogOnScreen(true);
    }

    @Override
    public void onDetach() {
        super.onDetach();
        FirstFragment fragment = getDoodleFragment();

        if (fragment != null)
            fragment.setDialogOnScreen(false);
    }

    
    private final OnSeekBarChangeListener lineWidthChanged =
            new OnSeekBarChangeListener() {
                final Bitmap bitmap = Bitmap.createBitmap(
                        400, 100, Bitmap.Config.ARGB_8888);
                final Canvas canvas = new Canvas(bitmap); // piirtää bittikarttaan

                @Override
                public void onProgressChanged(SeekBar seekBar, int progress, boolean fromUser) {
                    Paint p = new Paint();
                    p.setColor(
                            getDoodleFragment().getDoodleView().getDrawingColor());
                    p.setStrokeCap(Paint.Cap.ROUND);
                    p.setStrokeWidth(progress);

                    bitmap.eraseColor(
                            getResources().getColor(android.R.color.transparent,
                                    getContext().getTheme()));
                    canvas.drawLine(30, 50, 370, 50, p);
                    widthImageView.setImageBitmap(bitmap);
                }

                @Override
                public void onStartTrackingTouch(SeekBar seekBar) { // tarvitaan

                }

                @Override
                public void onStopTrackingTouch(SeekBar seekBar) { // tarvitaan

                }
            };

}

@a_local_nobody I checked that thread, but I am still not sure what's wrong with my code. So not really. — QuestionsAndAnswers, Aug 06 '20 at 17:22

score 0 · Answer 1 · edited Aug 07 '20 at 07:01

Your error says the following: null object reference

This means that 1 object gives the value 0. Your code looks fine but if you rewrite the code once again you may solve the mistake. It is caused by a pitty error in your code. When rewriting it. You can find that error. Even if this was a bug with some plugin or anything else. Also after you rewrote it, if you get the same error then you need to look onto a reference.

Android app has stopped and attempt to invoke virtual method on a null object reference

1 Answers1