is there a way to make two elements pick random items from a array but won't be the same item - Javascript

Question

I have created a function where two different elements (randomColor1 and randomColor2) picks a color from the array. But the problem is sometimes both the elements(randomColor1 and randomColor2) pick the same color.

The value of both the element comes the same.

Here are my codes. Can you please tell me what is the exact code to rectify the issue. I want both elements selects different colors every from each other. I am new to javascript.

function GetValue() {
  var myarray = new Array("#ff0000", "#ffe100", "#95ff00", "#2c8d94","#911961");

  var randomColor1 = myarray[Math.floor(Math.random() * myarray.length)];
  var randomColor2 = myarray[Math.floor(Math.random() * myarray.length)];
  
  document.getElementById("message").innerHTML = randomColor1 + randomColor2;
}

You could remove the colors from the array as you assign them to the random variables. — Sean, Aug 10 '20 at 17:43
@epascarello Isn't that what `myarray[Math.floor(Math.random() * myarray.length)]` is doing? — Rob Moll, Aug 10 '20 at 18:26
@RobMoll um, shuffling it, it is random, no need to track what is used. How you play with cards and pull the card off the deck??? — epascarello, Aug 10 '20 at 18:46
https://stackoverflow.com/questions/2450954/how-to-randomize-shuffle-a-javascript-array — epascarello, Aug 10 '20 at 18:46

score 4 · Accepted Answer · answered Aug 10 '20 at 17:42

Just remove the element that you are taking out of the array, to ensure you won't pick the same one again:

var randomColor1 = myarray.splice(Math.floor(Math.random() * myarray.length), 1)[0];
var randomColor2 = myarray.splice(Math.floor(Math.random() * myarray.length), 1)[0];

is there a way to make two elements pick random items from a array but won't be the same item - Javascript

1 Answers1