I have an application with decoupled front-end and back-end and I'm trying to figure out 2 things:
- What response should I return when the user tries to log in with wrong credentials
- After returning the response, how to indicate to the user that the credentials he has used are wrong
Right now I have the following function used for login a user. If a user with that email does not exist, I send a 401 response. If a user exists, I check if his password is correct, and if it is I return a 200 response with all the data. If the password is incorrect, I send 401 response.
module.exports.loginUser = async (req, res, next) => {
let email = req.body.email
let password = req.body.password
let userExists = await User.findOne({
where: {
email: email
}
})
if (userExists) {
bcrypt.compare(password, userExists.password, (error, result) => {
if (result) {
let token = jwt.sign({ id: userExists.id, email: userExists.email }, 'secretkey')
res.status(200).json({
message: 'Authentication succeeded',
username: userExists.username,
userId: userExists.id,
token: token
})
} else {
res.status(401).json({
message: 'Authentication failed'
})
}
})
} else {
res.status(401).json({
message: 'Authentication failed'
})
}
}
On the front-end, I have a Login view with the following code:
<template lang="html">
<div class="register">
<div class="register-container">
<p>Welcome back!</p>
<form @submit.prevent="onSubmit" novalidate>
<div class="margin-bottom-20">
<p>Email</p>
<input v-model='email' type='email'>
</div>
<div class="margin-bottom-20">
<p>Password</p>
<input v-model='password' type="password">
</div>
<button type="submit" name="button">Continue</button>
</form>
</div>
</div>
</template>
<script>
import axios from 'axios'
export default {
data(){
return {
email: '',
password: '',
}
},
methods: {
onSubmit(){
let userInfo = {
password: this.password,
email: this.email
}
this.$store.dispatch('login', userInfo)
}
}
}
</script>
And my store:
const store = new Vuex.Store({
state: {
token: null,
username: null,
userId: null,
},
mutations: {
authUser(state, userData){
state.token = userData.token
state.userId = userData.userId
state.username = userData.username
localStorage.setItem('token', userData.token);
localStorage.setItem('userId', userData.userId);
localStorage.setItem('username', userData.username);
}
},
actions: {
login({commit, dispatch}, userInfo){
axios.post('/login', userInfo)
.then(response => {
commit('authUser', {
token: response.data.token,
userId: response.data.userId,
username: response.data.username
})
router.replace('/')
}).catch((error) => console.log(error));
},
}
}
Now I'm not quite sure how to correctly and cleanly add functionality to the front-end that will render error if the user has added incorrect credentials. In order to render the error on the front-end, I'd have to send something in the response from the back-end to the front-end that will indicate that an error has occurred. Sadly, I'm not sure what exactly should I send.