This will not return the "if" statement, even though terms are met

Question

This code should detect where a number is above 1,000,000,000 and below 9,999,999,999. I try to input numbers between these 2 values, but it still returns the else statement. Where is the problem in this code?

<html>
<head>
<title>Checking with RegExp</title>
</head>
<body>
<p>Enter a 10 digit number between 1000000000 and 9999999999.</p>
<textarea id="inputnumber"></textarea>
<button type="button" id="submitnumber">Check</button>
<script>
function checknumber() {
var tendigitnum = document.getElementById("inputnumber")
if (tendigitnum >= 1000000000 && tendigitnum <= 9999999999) {
alert("You entered the number" + tendigitnum + ".")
}
else {
alert("The page will refresh. Please enter a valid number.")
location.reload()
}
}
document.getElementById("submitnumber").onclick = checknumber
</script>
</body>
</html>

If you can confirm that input value will be number, then just check the length of the input value... Don't forget to use `.value` after element object. — vaku, Aug 18 '20 at 16:22

T.J. Crowder · Accepted Answer · 2020-08-18T16:19:49.600

You're comparing an HTML element to a number. You want to compare a number to a number, by:

Using the .value property on the element to get the string, and
Parsing that string to a number (you have lots of different ways to do this depending on your use case; see this answer for a list of them)

For instance:

var tendigitnum = Number(document.getElementById("inputnumber").value);

Live Example:

function checknumber() {
  var tendigitnum = Number(document.getElementById("inputnumber").value)
  if (tendigitnum >= 1000000000 && tendigitnum <= 9999999999) {
    alert("You entered the number" + tendigitnum + ".")
  } else {
    alert("The page will refresh. Please enter a valid number.")
    location.reload()
  }
}
document.getElementById("submitnumber").onclick = checknumber

<p>Enter a 10 digit number between 1000000000 and 9999999999.</p>
<textarea id="inputnumber"></textarea>
<button type="button" id="submitnumber">Check</button>

On modern browsers you could use a number input:

<input type="number" id="inputnumber">

and use its valueAsNumber property instead of value, since valueAsNumber will already be a number. You can even add the range validation to the input. More on MDN.

That's it, also consider making the input type "number" instead of textarea, if all you want to do is getting number. — VG-Electronics, Aug 18 '20 at 16:17
Thank you @T.J. Crowder , this fixed my problem and my code runs smooth! — coding_makes_no_sense, Aug 18 '20 at 16:19

score 0 · Answer 2 · answered Aug 18 '20 at 16:17

0

You need to check the value in your element, in your code you are checking element

answered Aug 18 '20 at 16:17

Biju Kalanjoor

532
1
6
12

This will not return the "if" statement, even though terms are met

2 Answers2