javascript logical operators are not working

Question

I am createing discord bot, that will do a coinflip, but i got some logical operator errors that i cant figure out whats wrong. I want that bot will respond on command if its not full command and between some strings it doesnt work. Here is whats wrong - If I type !coinflip blue - it works, the bot respond me to "choose currency" BUT IF I TYPE !coinflip red - then bot still thinks that theres nothing after !coinflip and it will say "choose a side". Please help.

if (args[0] !== ('blue'||'red')) {
    message.reply('If you do not know how to create coinflip type **!help**');
    message.reply('Choose a side [blue, red]. [Example: !coinflip **blue**].');

  } else if (args[0] === ( 'blue' || 'red' )) {
        if (args[1] !== 'ref' || args[1] !== 'key') {
          message.reply('*If you do not know how to create coinflip type **!help***');
          message.reply('Choose a currency [ref, key]. [Example: !coinflip blue **key**].');
    } else if (args[1] === 'ref' || args[1] === 'key') {etc...}

`'blue'||'red'` always evaluates to `blue`, since it's a truthy value, check each value independently. — msg, Sep 02 '20 at 14:34
do you mean new if statements ??? thats a lot of coding... is there any other way ?? — EnelGy, Sep 02 '20 at 14:36
After you fix the obvious issue with values being more than one option, I have a feeling you have a big logic error. You need to layout the logic so the most specific things are at the top and the least are at the bottom. — epascarello, Sep 02 '20 at 14:59

score 0 · Answer 1 · answered Sep 02 '20 at 14:35

Rewrite this:

if (args[0] !== ('blue'||'red')) {

As any of the following:

if (args[0] !== 'blue' && args[0] !== 'red') {

if (!['blue', 'red'].includes(args[0])) {

if (!/blue|red/.test(args[0])) {

This last option resembles your current attempt most closely.

score 0 · Answer 2 · answered Sep 02 '20 at 14:37

0

if (args[0] !== ('blue'||'red')) {

Needs to be

if ((args[0] !== 'blue') && (args[0] !== 'red')) {

'blue'||'red' will just be 'blue', which isn't what you want, assuming you want to compare args[0] to 'blue' and 'red'

answered Sep 02 '20 at 14:37

ControlAltDel

33,923
10
53
80

i made changes but when i wrote !coinflip red, it didnt show anything – EnelGy Sep 02 '20 at 14:42

javascript logical operators are not working

2 Answers2