Codeigniter 4 'update' from Controller

Question

I'm so confused...

This function runs OK and doesn't throw up any errors... but it doesn't update the row in my table.

Where have I gone wrong?

Controller:

    public function update()
    {     
        $model = new StoreModel();
      
        $model->where('merchant', 'Klip Shop')->set('availability', 'out of stock')->update();
        
    }

Model:

class StoreModel extends Model
{
    protected $table = 'shop';
}

does `$model->where('merchant', 'Klip Shop')->get()` return anything? — Vickel, Sep 16 '20 at 17:07
[@Vickel](https://stackoverflow.com/users/2275490/vickel) Nothing. Not even "NULL" when I `var_dump` it. — seixwebdev, Sep 16 '20 at 17:53
I've update my answer, after looking into your controller and model, hope this will work now — Vickel, Sep 16 '20 at 20:51

score 1 · Answer 1 · answered Sep 17 '20 at 19:14

1

It was an $allowedFields issue with the model, hence nothing was 'allowed' to be updated.

answered Sep 17 '20 at 19:14

seixwebdev

111
2
4
14

Vickel · Answer 2 · 2020-09-17T12:54:35.077

0

Since $model->where('merchant', 'Klip Shop')->get() doesn't return anything, it means that you don't have any data you can update.

You need to insert a row first.

you could use the insert() function, if there is no rows detected with the merchant name

or

there is the save() function in CI 4.x which either inserts or updates on duplicate. but to get it to work, you need to set merchant to unique or use a column with an unique key

please read: Saving Data in CI 4.x

edit: you actually got me confused too:

only now I analized your MCV code:

you should have a controller

public function update()
{     
    $model = new StoreModel();
    $model->update();
}

and a model:

class StoreModel extends Model
{
    $db      = \Config\Database::connect();
    $model= $db->table('shop');

    function update(){
        $model->where('merchant', 'Klip Shop')->set('availability', 'out of stock')->update();
    }
}

edited Sep 17 '20 at 12:54

answered Sep 16 '20 at 18:10

Vickel

7,879
6
35
56

[@Vickel](https://stackoverflow.com/users/2275490/vickel) THAT'S why I'm so confused... there's literally THOUSANDS of matching entries in my database to update. No spelling mistakes or anything. – seixwebdev Sep 16 '20 at 18:23
can you create a small sqlfiddle? something like: http://sqlfiddle.com/#!9/a6c585/1 – Vickel Sep 16 '20 at 18:30
[@Vickel](https://stackoverflow.com/users/2275490/vickel) This is it: http://sqlfiddle.com/#!9/bf443f Thank you for all your help! – seixwebdev Sep 16 '20 at 18:52
check http://sqlfiddle.com/#!9/52bc7f/1: the left hand panel now updates your existing merchant, if you change the merchant's name to one, which doesn't exist, it cannot update and give an error, therefor the CI 4.x save() function, which practically generates this SQL: https://stackoverflow.com/a/14383597/2275490 – Vickel Sep 16 '20 at 19:10
[@Vickel](https://stackoverflow.com/users/2275490/vickel) Thank you for all the time you’re spending helping me with this. It’s really appreciated! Isn’t what you’ve coded in MySQL the same as what I originally coded for my Controller though? What I’ve coded for my Controller isn’t updating the data but it looks like the same logic as yours... What do I need to change in my Controller to do the update? – seixwebdev Sep 16 '20 at 19:33
I've added the line `UPDATE shop SET availability = 'not in stock' WHERE merchant = 'Notino.co.uk'`at the left hand side, therefore if you run the query (Run SQL) you'll see the updated output. But yes it is following the sample you gave. Use `echo $model->getCompiledSelect();` and see the generated SQL – Vickel Sep 16 '20 at 19:39
[@Vickel]() Isn't this (your code): `UPDATE shop SET availability = 'not in stock' WHERE merchant = 'Notino.co.uk'` the same as (my code): `$model->where('merchant', 'Notino.co.uk')->set('availability', 'not in stock')->update();`? The latter isn't updating my database. I understand the MySQL code/logic behind what I'm trying to do, but I need to do it in a Query Builder Class function in a Controller as it's not a one-off task. – seixwebdev Sep 16 '20 at 19:54
no, because you query for "Klip Shop", with ` $model->where('merchant', 'Klip Shop')->set('availability', 'out of stock')->update();` and not for Notino.co.uk – Vickel Sep 16 '20 at 20:25

Codeigniter 4 'update' from Controller

2 Answers2