Bad practice to put = inside javascript if statement?

Question

Possible Duplicate:
Javascript : assign variable in if condition statement, good practice or not?

Is it bad practice to assign/evaluate things inside an if statement?

eg.

var foo;
var bar = function() { .. }

if(foo = bar()) {
    ..
}

You could have it all (excluding the `var` declaration) in the `if()` if you really want to: `var foo, bar; if( foo = (bar = function() { /***/ })() ) { /***/ }` — user113716, Jun 18 '11 at 18:26

score 3 · Answer 1 · answered Jun 18 '11 at 18:20

3

Functionality-wise there's absolutely nothing wrong with that. But if you're going for readability, keep in mind that more junior members of your team (if any) may have a tougher time with less straight forward syntax as this.

answered Jun 18 '11 at 18:20

Kon

27,113
11
60
86

Gaz · Answer 2 · 2011-06-18T18:30:20.583

1

This will work fine and is not bad practice in Javascript.

JSLint might not agree with me though ;-)

edited Jun 18 '11 at 18:30

answered Jun 18 '11 at 18:18

Gaz

1,570
2
17
22

It's *not* bad practice? Based on what? – Metagrapher Jan 08 '12 at 15:03

Bad practice to put = inside javascript if statement?

2 Answers2