How can i split text input to a list in C++?

Question

I can split a given text into a list, but it doesn't work if I want to split a string given by the user.

void removeDupWord(string str)
{
    string word = "";
    for (auto x : str)
    {
        if (x == ' ')
        {
            cout << word << endl;
            word = "";
        }
        else
        {
            word = word + x;
        }
    }
    cout << word << endl;
}

int main()
{
    string ss;
    cin >> ss;
    ss = "split this";
    removeDupWord(ss);
}

If you want to split a string given by the user, you should use `getline()`. With your method, you get the first word only in string `ss`. — Damien, Oct 05 '20 at 09:26
Insted of `cin >> s`, use `std::getline(std::cin, ss);`. https://en.cppreference.com/w/cpp/string/basic_string/getline — Damien, Oct 05 '20 at 09:30
you are making assumptions about your code that don't hold. You can use a debugger or print `ss` after reading it from the user to see where the actual issue is — 463035818_is_not_an_ai, Oct 05 '20 at 09:33
OT: you shoud change `removeDupWord(string str)` to `removeDupWord(const string & str)` for efficiency reasons. — Jabberwocky, Oct 05 '20 at 09:36

score 1 · Accepted Answer · answered Oct 05 '20 at 09:36

Use std::getline instead of std::cin. With std::cin the input after whitespace will be discarded.

int main()
{
    string ss;
    std::getline(std::cin, ss);
    //ss = "split this";
    removeDupWord(ss);
}

Also, you should use C++ standard algorithm for such trivial task

void removeDupWord(const std::string& str)
                 // ^^^^^^^^^^^^^^^^^ Noice this change
{
    std::stringstream ss(str);
   
    std::copy(std::istream_iterator<std::string>{ss}, 
              std::istream_iterator<std::string>{},
              std::ostream_iterator<std::string>(std::cout, "\n"));
}

Demo Here

@P0W Why are you writing "std::istream_iterator{}" as 2nd parameter to ````std::copy````? A simple "{}" would be sufficient. Like ````std::copy(std::istream_iterator(ss), {}, std::ostream_iterator(std::cout, "\n"));```` — A M, Oct 05 '20 at 15:15

How can i split text input to a list in C++?

1 Answers1