I have a problem with my indentation and it's making the program unresponsive

Question

    zero = False

    while not zero:    
         nombre = int(input("Entrez un nombre entier positif (0 pour terminer): "))
         facteurs = []

    if nombre == 0:
        zero = True
    else:
        while nombre % 2==0:
            facteurs.append(2)
            nombre //= 2

    diviseur = 3
    while nombre != 1 and diviseur <= nombre:
        if nombre % diviseur == 0:
            facteurs.append(diviseur)
            nombre //= diviseur
        else:
            diviseur += 2

    print("La décomposition en facteurs premiers est: ") 
    print(*facteurs, sep=" * ")

*** So this is my code now I need the program to restart when the user input is not zero but now that I added my line // zero = False // My program doesn't print any answer and completely ignores the rest of the code. What is happening and how can I fix it ??

Thank you for your help !

It looks like your indentation is messed up. For example, your condition to check if the input value is 0 is outside of the while loop. — ElectricShadow, Oct 05 '20 at 18:02
hello and welcome to SO. Please, take your time to take a tour of the site before posting. Your title is not attractive, and the post is poorly formatted. — Daemon Painter, Oct 05 '20 at 18:03
does this help? https://stackoverflow.com/questions/15347174/python-finding-prime-factors — Ironkey, Oct 05 '20 at 18:06
can you post the stacktrace generated when you run your code — Paddy Popeye, Oct 05 '20 at 19:05

score 0 · Accepted Answer · answered Oct 05 '20 at 18:12

Your line states that zero = False.

Your code will run while not zero, which is equivalent to say while zero is False. So you'll enter this decision branch: if your input is 0, I'm immediately prompt again with the question for my input. Otherwise, you go in the other branch.

Now, since your indentation is messed up, the final statement printing the answer is outside of the first while loop. You'll run until diviseur += 2 and start all over again, never exiting, since the second branch never sets zero = True.

Thank you for your help and for your comment on my formatting !! Sorry if it was hard to understand — Cold Kendama, Oct 05 '20 at 18:21

score 0 · Answer 2 · answered Oct 05 '20 at 18:17

nombre = -1

while nombre < 0:
    nombre = int(input("Entrez un nombre entier positif (0 pour terminer): "))
    
    if nombre == 0:
        break
    elif nombre > 0:
        facteurs = []

        while nombre % 2==0:
            facteurs.append(2)
            nombre //= 2

        diviseur = 3
        while nombre != 1 and diviseur <= nombre:
            if nombre % diviseur == 0:
                facteurs.append(diviseur)
                nombre //= diviseur
            else:
                diviseur += 2

        print("La décomposition en facteurs premiers est: ") 
        print(*facteurs, sep=" * ")

score 0 · Answer 3 · answered Oct 05 '20 at 19:14

With the indentation below your code runs with the expected behaviour... Tested with Python3.7 in Spyder4

zero = False
while not zero:
    nombre = int(input("Entrez un nombre entier positif (0 pour terminer): "))
    facteurs = []

    if nombre == 0:
        zero = True
    else:
        while nombre % 2==0:
            facteurs.append(2)
            nombre //= 2

    diviseur = 3
    while nombre != 1 and diviseur <= nombre:
        if nombre % diviseur == 0:
            facteurs.append(diviseur)
            nombre //= diviseur
        else:
            diviseur += 2
    print("La décomposition en facteurs premiers est: ") 
    print(*facteurs, sep=" * ")

I have a problem with my indentation and it's making the program unresponsive

3 Answers3