6

I notice sample codes I read on SerialPort closing and opening where people would add Thread.Sleep(1000) before SerialPort.Open() and Close(). Like the following:

Thread.Sleep(1000);
serialPort1.Open();
/* some code */
Thread.Sleep(1000);
serialPort1.Close();

I cannot find any explanation anywhere. Why do people block the serial port using Thread.Sleep before it gets Open or Close? Is it for some timing purpose? Am I supposed to put a Thread.Sleep whenever I read from or write to Serial Port as well?

KMC
  • 19,548
  • 58
  • 164
  • 253
  • that would make more sense if the sleep was after openning and after closing to give it time to either establish or end a connections – Prix Jun 22 '11 at 02:40
  • I know in the bad old days of ISA, you'd have to be careful not to send stuff to ports too quickly or it'd cause issues. I wonder how much of that is still the case, and how much of it is cargo cult'ism? – cHao Jun 22 '11 at 02:43

3 Answers3

10

When you open a port, the SerialPort class fires up a new thread under the hood which is responsible (via the WaitCommEvent Windows API function) for waiting for serial port activity (e.g. data arrived) and firing the appropriate events to your handlers. That's why events like DataReceived actually occur on a secondary thread.

When you close the port, the Close() call returns immediately but it takes some time for the secondary thread to spin down.

If you attempt to re-open the port too quickly after calling Close, and the thread hasn't yet spun down, then the SerialPort instance is not in a state where it can begin a new connection.

Note the MSDN documentation for SerialPort.Close states:

The best practice for any application is to wait for some amount of time after calling the Close method before attempting to call the Open method, as the port may not be closed instantly.

You could keep track of when you closed the port, and before opening it again make sure some arbitrary timeout has elapsed.

No need to sleep before reads / writes, although a few quirks to keep in mind:

Keep in mind the SerialPort class in the .NET BCL still relies on the underlying Win32 API, and I don't think it's gotten a lot of love from Microsoft since the initial implementation.

For more information see:

Community
  • 1
  • 1
rkagerer
  • 4,157
  • 1
  • 26
  • 29
3

Only one open connection can exist per SerialPort object. The best practice for any application is to wait for some amount of time after calling the Close method before attempting to call the Open method, as the port may not be closed instantly.

Have a look at this link.

Bibhu
  • 4,053
  • 4
  • 33
  • 63
1

I have done a few Serial I/O programs in C# and I don't think I've never added sleeps like that. I've experienced no ill effects (with the caveat that my apps never tried to open and close the serial port in quick succession)

You definitely should not have to sleep before reading or writing.

Tremmors
  • 2,906
  • 17
  • 13