3

Spring cache is not working when calling cached method from another method of the same class.

Here is an example to explain my problem in clear way.

Cached service class:

class testServiceImpl{

@CachePut(key = "#result.id", condition = "#result != null")
public List<String> create(String input) {
......
}

@CacheEvict(key="#id")
public void deleteById(Long id) {
.....
}

public void multiDelete(String input) { 
if(condition...){
  deleteById(2);  //Cache is not Evicted here i.e. the records are still present in getAll call but not in Database.
}else{
  create(input); //New Data is persisted in DB but the same has not been updated in Cache.
}   

@Transactional
@Cacheable
public Map<Long, String> getAll() {
 ...
}

I have tried using the below solutions as well but could not succeed.

//Create a new object of the same class and use the same. In this case, the data is not persisted in DB i.e. it is not deleting the data from DB.
     testServiceImpl testService;
                ...
              public void multiDelete(String input) {   
                if(condition...){
                  testService.deleteById(2);  
                }else{
              testService.create(input); 
            }

Can someone please help me to solve this issue ?

Amit Agarwal
  • 67
  • 1
  • 1
  • 12
  • 2
    Have you looked at this ? https://stackoverflow.com/questions/16899604/spring-cache-cacheable-not-working-while-calling-from-another-method-of-the-s?rq=1 – Shawrup Oct 14 '20 at 12:58
  • The answer of @cdalxndr is correct. A better solution than using AspectJ is to call the cache directly. You can do that by incecting the `CacheManager` and call `getCache(name)` – cruftex Oct 14 '20 at 19:58

1 Answers1

5

When you call a method from your service, you are actually calling it through a proxy. The autowired bean is wrapped in a proxy that intercepts the call and handles the cache annotations only for that method.

When you make the call internally, it is made directly on the service object, and without the proxy wrapper, the cache annotation is not processed. See Understanding AOP Proxies

A working alternative is to use AspectJ that will weave the spring aspects that handle cache annotations directly into the code without using any Spring proxies, so you can call internal methods and cache annotation will be handled as expected.

cdalxndr
  • 1,435
  • 1
  • 15
  • 20
  • Could you give an example with AspectJ ? How can I use AspectJ here to solve this issue ? – Amit Agarwal Oct 14 '20 at 13:55
  • @AmitAgarwal personally I would advice against using AspectJ as you can enter a world of hard to debug issues. If you feel adventurous, basically you need to use `spring-boot-starter-aop`, add `spring-aspects` dependencies, set `@EnableCaching(mode = AdviceMode.ASPECTJ)`, and add VM option `-javaagent:` for load time weaving. – cdalxndr Oct 14 '20 at 14:15