Unable to pass function pointer as function param

Question

I would like to pass function pointer as a function parameter.

Here is my code:

void AuthServerOpcodes::ValidateAndSetServerOpcode(ServerOpcode serverOpcode, void(*handlerFunc(std::vector<std::byte> data))) {}

Here is the function I would like to pass as second parameter in ValidateAndSetServerOpcode:

void AuthServerOpcodes::Test(std::vector<std::byte> data) {
    std::cout << "all good" << std:end
}

Here is how I try to pass it:

ValidateAndSetServerOpcode(SMSG_LOGIN_REQUEST, &Test);

However this seems to be not the correct way. When I try to do it in that way I get error:

Cannot initialize a parameter of type 'void (*(*) 
(std::vector<std::byte>))' with an rvalue of type 'void 
(AuthServerOpcodes::*)(std::vector<std::byte>)': different return type 
('void (*)' vs 'void')

Why is that and how can I fix it?

Does this answer your question? [Call a member function with bare function pointer](https://stackoverflow.com/questions/3149407/call-a-member-function-with-bare-function-pointer) — Stephen Newell, Oct 21 '20 at 11:26

score 1 · Accepted Answer · answered Oct 21 '20 at 12:27

Pointers to member must be qualified with the class type, so you need to get the pointer you'll need to use

ValidateAndSetServerOpcode(SMSG_LOGIN_REQUEST, &AuthServerOpcodes::Test);

But it looks like you've tried that in the previous edit, so I guess you've called the function pointer to member incorrectly. You didn't show a minimal, reproducible example so I can't help you more, please create one. Anyway I've created a compiled example on Compiler Explorer

typedef void (AuthServerOpcodes::*HandlerFunc)(std::vector<std::byte> &);

void AuthServerOpcodes::ValidateAndSetServerOpcode(ServerOpcode serverOpcode,
        HandlerFunc handlerFunc)
{
    std::vector<std::byte> myVector;
    (this->*handlerFunc)(myVector);   // call the hander
}

void FreeStandingFunction(AuthServerOpcodes& opc,
    AuthServerOpcodes::HandlerFunc handlerFunc,
    std::vector<std::byte> &data)
{
    (opc.*handlerFunc)(data);
}

As you can see the pointer to member must be called with ->* or .* and the whole dereferencing must be wrapped inside () because those operators has lower precedence than the function call operator ()

See also Function pointer to member function

Some off-topic note:

Don't use lines that are too long like that
Don't pass vectors by values unless you really need to preserve the outside value. Always pass by reference with const std::vector<>& (or remove const to modify the outside variable)
Use '\n' instead of std::endl

score 0 · Answer 2 · answered Oct 21 '20 at 11:26

0

You can't do that.

There is no function pointer to that function, because it is a member function.

You can instead pass a pointer-to-member-function, or better yet a std::function bound to a lambda that captures the this pointer.

answered Oct 21 '20 at 11:26

Asteroids With Wings

17,071
2
21
35

So I can pass pointer to functions in same class or as well as parent class functions ? – Venelin Oct 21 '20 at 11:30
What about friend classes ? – Venelin Oct 21 '20 at 11:31
@AsteroidsWithWigns I have updated my question with the suggested by you changes to call member function but it still does not work. – Venelin Oct 21 '20 at 11:41
@AsteroidsWithWigns can you please make an example about `std::function` so the answer may be complete and I can accept it? – Venelin Oct 21 '20 at 12:08
You can trivially find one yourself with ten seconds of research. – Asteroids With Wings Oct 21 '20 at 14:23

score 0 · Answer 3 · answered Oct 21 '20 at 11:33

0

It's just a type mismatch, your function is a method of the AccountManager class, so it has this signature similar to: static void Login(AccountManager *this, std::vector<..> data);

You can either detach function from class, change your type definition of handlerFunc or consider different techniques like std::mem_fn or std:bind

https://en.cppreference.com/w/cpp/utility/functional/mem_fn https://en.cppreference.com/w/cpp/utility/functional/bind

answered Oct 21 '20 at 11:33

oshamash

1

Thank you for your answer! So If I create a function in `AuthServerOpcodes` I can pass it instead? Can you make an example with `std::bind` ? – Venelin Oct 21 '20 at 11:37

Unable to pass function pointer as function param

3 Answers3