Sonarqube complaining about unused variable in for loop

Question

In my project I have a simple function that calculates the length of an iterable (as I don't think there is an easy way to get it? No .size() or .length() is accepted?) Here is the code:

public int getIterableSize(Iterable<User> users){
        int size = 0;

        for(User user : users){
            size++;
        }

        return size;
    }

I also use Sonarqube to keep my code quality and I get the following code smell about this function:

Remove this unused "user" local variable.

There must be an easy way to get rid of this right? Maybe an alternative for the for loop, maybe a different function provided by iterable?

your function can return like this. `return users.stream().count();` — Pandey Amit, Oct 30 '20 at 10:32
@PandeyAmit iterable doesn't seem to have a function for stream() — Pim_vh, Oct 30 '20 at 10:33
Does this answer your question? [Get size of an Iterable in Java](https://stackoverflow.com/questions/11598977/get-size-of-an-iterable-in-java) — DPWork, Oct 30 '20 at 11:01

score 2 · Answer 1 · answered Oct 30 '20 at 12:59

You can annotate it with @SuppressWarnings("unused").

Either the method:

@SuppressWarnings("unused")
public int getIterableSize(Iterable<User> users){
    int size = 0;

    for(User user : users){
        size++;
    }

    return size;
}

Or the variable:

public int getIterableSize(Iterable<User> users){
    int size = 0;

    for(@SuppressWarnings("unused") User user : users){
        size++;
    }

    return size;
}

Various IDEs can automatically offer both of these fixes.

Sonarqube complaining about unused variable in for loop

1 Answers1