how to Copy files from path to path with ProgressBar in java

Question

i hope you are fine. i have here a code i took it from this site, for copy files from path to path. i want to use a progressBar with it, how do i use the progressBar with the counter?

i used the bellow code, and there's is no progress in progressBar ! this is the code :

progressbar1 = (ProgressBar) findViewById(R.id.progressbar1);
    progressbar1.setMax((int)100);  

    java.io.File filein  = new java.io.File("/storage/emulated/0/Alarms/test.zip");
    java.io.File fileout = new java.io.File("/storage/emulated/0/testcopied.zip");
    java.io.FileInputStream  fin  = null;
    java.io.FileOutputStream fout = null;
    long length  = filein.length();
    long counter = 0;
    int r = 0;
    byte[] b = new byte[1024];
    try {
            fin  = new java.io.FileInputStream(filein);
            fout = new java.io.FileOutputStream(fileout);
            while( (r = fin.read(b)) != -1) {
                    counter += r;

                    int k = (int)counter;
                    progressbar1.setProgress((int)k);
                    System.out.println( 1.0 * counter / length );
                    fout.write(b, 0, r);

            }
    }
    catch(Exception e){
            System.out.println("foo");
    }

`progressbar1.setProgress((int)k);` Well you are already setting the progress bar with the value of the counter. So what is the problem exactly? — blackapps, Nov 09 '20 at 20:10
Hey! Could you post the site link again. I think you didn't link it properly. But usually you split the calculations appart from rendering via multithreading. — Valentin, Nov 09 '20 at 20:38
@Valentin which site brother ? i just got the code from here "stackoverflow" without progressBar and then i tried to link it with progressBar without success i don't know where is the error — HishamKanon, Nov 09 '20 at 20:48
`the progress Bar don't Start ! (there's no progress)` I think it will indicate maximum inmediately. If you set maximum to 100 you will reach maximum after 100 bytes copied. I think the files are a little more then 100. — blackapps, Nov 09 '20 at 20:51
Here is a valid progress bar example. https://stackoverflow.com/a/8925656/12272930 I would suggest you try this one. The GUI is Swing but maybe you can adapt it. — Valentin, Nov 09 '20 at 20:54
@blackapps i used what you gave me, and now the progressBar do not start but when the file copied the progressBar get max directly — HishamKanon, Nov 09 '20 at 21:05
That is because you do all on the ui thread. The position/screen cannot be updated while your code runs. Only when your code has finished. Is there a progresbar.update() function? — blackapps, Nov 09 '20 at 21:38
@blackapps no brother, the code im using is the current i shared!, how i use update();? — HishamKanon, Nov 09 '20 at 22:59

score 3 · Accepted Answer · answered Nov 10 '20 at 03:59

In Android, for long-running operators such as download files from the network, access database, copying file, you should use a background thread to prevent the app from freeze or even crash.

To update progress bar's progress, you should do it in UI/main thread by using serveral mechanism such as runOnUiThread(Runnable) from Activity class or post(Runnable) from Handler class.

So your code will be:

public class MainActivity extends AppCompatActivity {

    ProgressBar progressbar1;

    // Use a background thread to copy files
    Thread copyingThread;

    // Use Handler to update progress bar's progress
    Handler mainHandler = new Handler(Looper.getMainLooper());

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        progressbar1 = (ProgressBar) findViewById(R.id.progressbar1);
        progressbar1.setMax(100);
        progressbar1.setProgress(0);

        copyingThread = new Thread(new Runnable() {
            @Override
            public void run() {
                File sourceFile = new java.io.File("/storage/emulated/0/Alarms/test.zip");
                File destFile = new java.io.File("/storage/emulated/0/testcopied.zip");
                FileInputStream fileInputStream;
                FileOutputStream fileOutputStream;
                long length = sourceFile.length();
                int bytesRead;
                int totalBytesRead = 0;
                byte[] buffer = new byte[4 * 1024]; // 4KB buffer
                try {
                    fileInputStream = new FileInputStream(sourceFile);
                    fileOutputStream = new FileOutputStream(destFile);

                    while (!Thread.currentThread().isInterrupted()
                            && (bytesRead = fileInputStream.read(buffer)) != -1) {
                        // Write bytesRead to destination file
                        fileOutputStream.write(buffer, 0, bytesRead);

                        // Calculate the copying percent
                        totalBytesRead += bytesRead;
                        int percent = (int) (totalBytesRead * 100 / length);
                        Log.i("DEBUG", "Copied: " + percent + "%");

                        // Update progress bar's progress in UI/main thread
                        mainHandler.post(new Runnable() {
                            @Override
                            public void run() {
                                progressbar1.setProgress(percent);
                            }
                        });
                    }
                } catch (Exception e) {
                    System.out.println("foo");
                }
            }
        });
        copyingThread.start();
    }

    @Override
    protected void onDestroy() {
        // Release copying thread's resource in case users leaving this activity
        if (copyingThread != null && copyingThread.isAlive()) {
            copyingThread.interrupt();
        }
        super.onDestroy();
    }
}

thank you so much brother that worked Fine, JUST the progressBar stop on the half and Re-run again but no problem its ok all my respect for you — HishamKanon, Nov 10 '20 at 11:15

how to Copy files from path to path with ProgressBar in java

1 Answers1