How do I store the values into this dict so that in the next iteration it would work?

Question

I'm not sure how to store the values taken from the user input (to generate new username and password) and store it in the iass dict, so in the next iteration it would work:

iass = {}

class login:
   def __init__(self):
     pass

   def passcheck(self):
     for key, value in iass.copy().items():
        if self.username == key and self.password == value:
            print("Granted Access")
        else:
            A = str(input("Enter Desired Name: "))
            B = str(input("Enter Desired Password: "))
            iass[A] = B


A1 = login()
A1.username = str(input("Enter Username: "))
A1.password = str(input("Password: "))
A1.passcheck()

Does this answer your question? [Modifying a Python dict while iterating over it](https://stackoverflow.com/questions/6777485/modifying-a-python-dict-while-iterating-over-it) — Christopher Peisert, Nov 22 '20 at 16:05

score 2 · Accepted Answer · answered Nov 22 '20 at 15:56

Your usage of a class/object is a little strange. Usually one would create a class for something that represents an object (a noun) in the real world. In your application, this might be User.

Login would be a method in that class.

Your method passcheck is also a bit strangely constructed. As you've just asked for the input of Username and Password, you can reuse these at all times. You don't need to ask them again. I'd recommend you to pass username and password as parameters in the login method, rather than setting them directly as parameters. Your code could look somewhat like this

iass = []

iass.append({'myuser': 'mypwd'})

class User:
   def __init__(self):
     pass

   def login(self, username, password):
     for key, value in iass.items():
        if username == key and password == value:
            print("Granted Access")
            return

     # User not found, so we're adding him
     iass.append({username: password})


A1 = User()
username = str(input("Enter Username: "))
password = str(input("Password: "))
A1.login(username, password)

Note: didn't run this in the python parser. might have some issues :-)

score 0 · Answer 2 · answered Nov 22 '20 at 16:56

Please run pylint on your code.

It will uncover bugs for you before you run it.
It will improve the code readability. This helps everyone: yourself and others who will read your code.

Code changes:

Remove the iass.copy() call. It was unnecessary; though not creating a bug.
To make the code "work" you need to initialize iass with a key and value:

iass = {"ding": "dong"}

Remove the else: block. That is causing an extra prompt which is only confusing and would be considered a bug.

Now when the user enters a username, password "ding" and "dong" your check will "pass".

How do I store the values into this dict so that in the next iteration it would work?

2 Answers2