How can I fix this if statement to not fail when returning null?

Asked Dec 05 '20 at 19:05

Active Dec 05 '20 at 19:51

Viewed 35 times

PHP Fatal error Uncaught Error: Call to a member function get_id() on null

Receiving error above in woocommerce / automatewoo.

EDIT I'm trying to end the function if $cart_item['data']->get_id() returns null:

 if( $value = get_post_meta( $cart_item['data']->get_id(), 
  'printful_variant_id', null ) ){
}
         return false;

Current example below:

add_filter( 'woocommerce_get_item_data', 'display_custom_field_as_item_data', 20, 2 );
function display_custom_field_as_item_data( $cart_data, $cart_item ) {
if( $value = get_post_meta( $cart_item['data']->get_id(), 'printful_variant_id', true ) ){
    $cart_data[] = array(
        'name' => __( 'Var ID', 'woocommerce' ),
        'value' => sanitize_text_field( $value )
    );
    
}
return $cart_data;
}

edited Dec 05 '20 at 19:51

asked Dec 05 '20 at 19:05

user2059376

3

It's not a problem with `get_id` *returning* `null`. It's a problem of *calling* `get_id` on `null`. Meaning `$cart_item['data']` is `null` at the moment when you try to get the id from it. – El_Vanja Dec 05 '20 at 19:08
Yes, thank you, that makes more sense. What would be the best approach to do nothing if `$cart_item['data']` is `null`? – user2059376 Dec 05 '20 at 19:12
3

Just check its value at the beginning. If it's empty, bail out of the function. – miken32 Dec 05 '20 at 19:13
@miken32 Something like this? `if( $value = get_post_meta( $cart_item['data']->get_id(), null ) ){ } exit();` – user2059376 Dec 05 '20 at 19:53
1

`if (!$cart_item['data']) { return; }` – El_Vanja Dec 05 '20 at 20:00
@El_Vanja Perfect. Worked. Thank you. – user2059376 Dec 05 '20 at 20:03

How can I fix this if statement to not fail when returning null?

0 Answers0