How to read whole binary file (not only the first variables) including string, long and int

Question

using (var fileStream = new FileStream("data.bin", FileMode.Append, FileAccess.Write))
using (var bw1 = new BinaryWriter(fileStream))
{
    bw1.Write(jmeno);
    bw1.Write(date);
    bw1.Write(rodnecislo);
    bw1.Write(sarze);
}

using (var fileStream = new FileStream("data.bin", FileMode.Open, FileAccess.Read))
using (var br1 = new BinaryReader(fileStream))
{
    string readname = br1.ReadString();
    int readdate = br1.ReadInt32();
    long readcislo = br1.ReadInt64();
    long readsarze = br1.ReadInt64();
    Console.WriteLine(readname);
    Console.WriteLine(readdate);
    Console.WriteLine(readcislo);
    Console.WriteLine(readsarze);
}

This is how the BinaryWriter looks like. I don't know how to make the console write this whole binary file.

This is the Binary writer. It works fine, but I want to display this binary file via console writeline — Kryštof Dušek, Jan 19 '21 at 13:56
Still don't get your problem, You have the code to write and to read. What exactly is missing or does not work? — Klaus Gütter, Jan 19 '21 at 14:00
@KlausGütter Right now it only reads the first string, int and long. But when I append something new, it doesnt display in console. So I would like to fix it, but I dont know how — Kryštof Dušek, Jan 19 '21 at 14:03
Have you thought about reading the four variables in a loop until the end of the file is reached? — Klaus Gütter, Jan 19 '21 at 14:04
@KlausGütter I have. But I dont know how to do it. I am new in this stuff. Or I can use method ReadAllBytes, but the enconding is wrong. — Kryštof Dušek, Jan 19 '21 at 14:06

score 0 · Answer 1 · answered Jan 19 '21 at 14:10

OK, then here is how to do it:

using (var fileStream = new FileStream("data.bin", FileMode.Open, FileAccess.Read))
using (var br1 = new BinaryReader(fileStream))
{
    while (br1.BaseStream.Position != br1.BaseStream.Length)
    {
        string readname = br1.ReadString();
        int readdate = br1.ReadInt32();
        long readcislo = br1.ReadInt64();
        long readsarze = br1.ReadInt64();
        Console.WriteLine(readname);
        Console.WriteLine(readdate);
        Console.WriteLine(readcislo);
        Console.WriteLine(readsarze);
    }
}

For an explanation of the while condition see e.g. here

How to read whole binary file (not only the first variables) including string, long and int

1 Answers1