Very easy SQL function returns boolean 1 (true) instead of resource

Question

I have this function

function query($query)
{
     return mysql_query($query) or die(mysql_error())
}

but when I call it like

$last = query("SELECT * FROM jubox ORDER BY id desc LIMIT 45");

$last returns 1

 echo $last; //1

What am I doing wrong?

EDIT:

I want to return RESOURCE id NOT DATA

It doesn't seem like you can get the resource ID (http://www.php.net/manual/en/language.types.resource.php). Why would you want to do that? — Matthieu Napoli, Jul 05 '11 at 11:46
beause mysql_fetch_assoc then gives me Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in /var/www/jukebox/fronta.... and i was just debugging (by echo — genesis, Jul 05 '11 at 11:47

score 3 · Answer 1 · answered Jul 05 '11 at 11:27

3

Currently, you are trying to echo out a resource, which returns 1 if valid (if echoing a resource, it does indeed echo 1)

You need to use a mysql_fetch_* function to get the data

answered Jul 05 '11 at 11:27

Jan Dragsbaek

8,078
2
26
46

but my point is to return resource id. How can I do it? IT works for me in my other project – genesis Jul 05 '11 at 11:38
it is probaly because 1 is your current resource ID then – Jan Dragsbaek Jul 05 '11 at 11:39
@genesis I think what you need to do is "*to use a mysql_fetch_\* function to get the data*" – Matthieu Napoli Jul 05 '11 at 11:41
NO I DO NOT ! I want to use it like $result = query("SELECT * FROM ..."); while($row = mysql_fetch_.....){} – genesis Jul 05 '11 at 11:41
WELL WHERE IS YOUR PROBLEM THEN? You have a resource, just **don't** echo it because it will be converted to a string... – Matthieu Napoli Jul 05 '11 at 11:42
because mysql_fetch_assoc gives me "Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in /var/www/jukebox/fr...." – genesis Jul 05 '11 at 11:45

score 3 · Accepted Answer · answered Jul 05 '11 at 11:57

Don't mix return and x OR y

<?php
$mysql = mysql_connect('localhost', 'localonly', 'localonly') or die(mysql_error());
mysql_select_db('test', $mysql) or die(mysql_error($mysql));
mysql_query('CREATE TEMPORARY TABLE jubox_so (id int auto_increment, primary key(id))') or die(mysql_error($mysql));

$last = query("SELECT * FROM jubox_so ORDER BY id desc LIMIT 45");
echo $last;

function query($query)
{
    $v = mysql_query($query);
    if ( !$v ) {
        die(myql_error());
    }
    return $v;
}

prints (something like) Resource id #6 as expected instead of 1 (which was caused by the bool->string conversion for echo)

score 1 · Answer 3 · answered Jul 05 '11 at 11:28

1

Look into mysql_fetch_* functions. They return actual rows for you. The mysql_query returns a link_identifier that can be used to fetch the results. See http://php.net/manual/en/book.mysql.php for the different functions available.

answered Jul 05 '11 at 11:28

toomasr

4,731
2
33
36

score 0 · Answer 4 · answered Jul 05 '11 at 11:29

0

You're echoing the result right? In case of a select this is a mysql result object and not true or false (like with update or insert). What you get is a result resource. You need to use functions as fetch_assoc to explore that result.

answered Jul 05 '11 at 11:29

hoppa

3,011
18
21

I think you didn't get me. I'm not amateur in PHP but this is very strange case when it does return bool instead of resource id ... – genesis Jul 05 '11 at 11:39

score 0 · Answer 5 · answered Jul 05 '11 at 12:03

0

i think the reason why you print out '1', is because your query result of an error and then it is the returned value of the die() that you get back. Check you query, copy and paste it in phpMyAdmin for exemple, and look for an error

answered Jul 05 '11 at 12:03

it worked in phpmyadmin, did you see that code ? There isn't syntax code! – genesis Jul 05 '11 at 12:04

Very easy SQL function returns boolean 1 (true) instead of resource

EDIT:

5 Answers5