If statement with String comparison fails

Question

I really don't know why the if statement below is not executing:

if (s == "/quit")
{
    System.out.println("quitted");
}

Below is the whole class.

It is probably a really stupid logic problem but I have been pulling my hair out over here not being able to figure this out.

Thanks for looking :)

class TextParser extends Thread {
    public void run() {
        while (true) {
            for(int i = 0; i < connectionList.size(); i++) {
                try {               
                    System.out.println("reading " + i);
                    Connection c = connectionList.elementAt(i); 
                    Thread.sleep(200);

                    System.out.println("reading " + i);

                    String s = "";

                    if (c.in.ready() == true) {
                        s = c.in.readLine();
                        //System.out.println(i + "> "+ s);

                        if (s == "/quit") {
                            System.out.println("quitted");
                        }

                        if(! s.equals("")) {
                            for(int j = 0; j < connectionList.size(); j++) {
                                Connection c2 = connectionList.elementAt(j);
                                c2.out.println(s);
                            }
                        }
                    }
                } catch(Exception e){
                    System.out.println("reading error");
                }
            }
        }
    }
}

== means; is this the same object. It doesn't match objects which contain the same data. — Peter Lawrey, Apr 28 '09 at 20:51

WiseTechi · Answer 1 · 2009-04-29T10:44:30.720

101

In your example you are comparing the string objects, not their content.

Your comparison should be :

if (s.equals("/quit"))

Or if s string nullity doesn't mind / or you really don't like NPEs:

if ("/quit".equals(s))

edited Apr 29 '09 at 10:44

answered Mar 18 '09 at 16:14

WiseTechi

3,528
1
22
15

1

I prefer s.equals("/quit"). It is cosmetically but I want to have the important current data (s) to be visible easily. – ReneS Mar 18 '09 at 16:24
4

s.equales("/quit") will throw a NullPointerException is s is null, "/quit".equals(s) will never throw an NPE – basszero Mar 18 '09 at 16:29
7

So "/quit".equals(s) will mask bugs where s is unintentionally null. – starblue Mar 18 '09 at 16:36
1

@starblue good point, always something else to consider – basszero Mar 18 '09 at 16:38
Well, another reason to have it s.equals()... might depend on the code, but the NPE is one reason to keep the current context upfront. – ReneS Mar 18 '09 at 17:10
1

@ReneS whatever string/context s is I'd still do "".equals(s) for I know won't be NULL whereas s might. But if s.equals(s2) then you are right, but then again you'll have to surround it with if(s!= null){ block. – Real Red. Mar 19 '09 at 03:59

TStamper · Answer 2 · 2009-04-29T04:27:03.687

38

To compare Strings for equality, don't use ==. The == operator checks to see if two objects are exactly the same object:

In Java there are many string comparisons.

String s = "something", t = "maybe something else";
if (s == t)      // Legal, but usually WRONG.
if (s.equals(t)) // RIGHT
if (s > t)    // ILLEGAL
if (s.compareTo(t) > 0) // also CORRECT>

edited Apr 29 '09 at 04:27

answered Mar 18 '09 at 16:21

TStamper

30,098
10
66
73

Checks to see that the references are the same. – Romain Hippeau Apr 23 '10 at 18:19

Bozho · Answer 3 · 2010-02-14T09:51:37.130

Strings in java are objects, so when comparing with ==, you are comparing references, rather than values. The correct way is to use equals().

However, there is a way. If you want to compare String objects using the == operator, you can make use of the way the JVM copes with strings. For example:

String a = "aaa";
String b = "aaa";
boolean b = a == b;

b would be true. Why?

Because the JVM has a table of String constants. So whenever you use string literals (quotes "), the virtual machine returns the same objects, and therefore == returns true.

You can use the same "table" even with non-literal strings by using the intern() method. It returns the object that corresponds to the current string value from that table (or puts it there, if it is not). So:

String a = new String("aa");
String b = new String("aa");
boolean check1 = a == b; // false
boolean check1 = a.intern() == b.intern(); // true

It follows that for any two strings s and t, s.intern() == t.intern() is true if and only if s.equals(t) is true.

score 5 · Answer 4 · edited Nov 27 '11 at 21:28

5

If you code in C++ as well as Java, it is better to remember that in C++, the string class has the == operator overloaded. But not so in Java. you need to use equals() or equalsIgnoreCase() for that.

edited Nov 27 '11 at 21:28

LPL

16,827
6
51
95

answered Nov 23 '09 at 22:10

user855

19,048
38
98
162

score 5 · Answer 5 · answered Mar 18 '09 at 16:18

5

You shouldn't do string comparisons with ==. That operator will only check to see if it is the same instance, not the same value. Use the .equals method to check for the same value.

answered Mar 18 '09 at 16:18

digitaljoel

26,265
15
89
115

score 5 · Answer 6 · answered Apr 14 '09 at 19:36

5

You can use

if("/quit".equals(s))
   ...

or

if("/quit".compareTo(s) == 0) 
    ...

The latter makes a lexicographic comparison, and will return 0 if the two strings are the same.

answered Apr 14 '09 at 19:36

littleduckie

585
1
4
7

If statement with String comparison fails

6 Answers6

Linked