Adding location data to openweather API

Question

My problem is when I try to add the ${lat} and ${long} to the API string. openweathermap docs say to put in numbers for the latitude and longitude but I want to have them inserted from the variables above that are gotten from 'position'

window.addEventListener('load', () => {
    let long;
    let lat;
    let temperatureDescription = document.querySelector('.temperature-description');
    let temperatureDegree = document.querySelector('.temperature-degree');
    let locationTimezone = document.querySelector('.location-timezone');

    if (navigator.geolocation) {
        navigator.geolocation.getCurrentPosition(position => {
            long = position.coords.longitude;
            lat = position.coords.latitude;

            console.log(position)

            const api = `api.openweathermap.org/data/2.5/weather?lat=**${lat}&lon=${long}&appid=<API-CODE>`;

            fetch(api)
                .then(response => {
                    return response.json();
                })
                .then(data => {
                    console.log(data);
                    const { temperature, summary } = data.currently;
                    // Set DOM elements from the API
                    temperatureDegree.textContent = temperature;
                    temperatureDescription.textContent = summary;
                });
        });
    }
});

denov · Answer 1 · 2021-01-29T01:30:42.130

0

based on https://openweathermap.org/current#geo you're missing the https so you should have

const api = `https://api.openweathermap.org/data/2.5/weather?lat=${lat}&lon=${long}&appid=${apiKey}`

edited Jan 29 '21 at 01:30

answered Jan 27 '21 at 21:17

denov

11,180
2
27
43

That was supposed to make it bold so the part I wanted help with would stand out but it didn't work. the ** are not in the original code. – Tyson Biegler Jan 27 '21 at 21:19
@TysonBiegler - i updated your example and my answer – denov Feb 10 '21 at 06:43

Adding location data to openweather API

1 Answers1