Reaplace many chars in string using c#

Question

I have a certain string, and I want to replace certain signs with same safe signs. So i decided to use regex for it, but I am doing something wrong.

Program looks like:

class Program
{
    static void Main(string[] args)
    {
        var bannedSignsAndReplacements = new Dictionary<string, string>
        {
            {"@", "A"},
            {"£", "L"},
            {"_", "-"},
            {"$", "S"},
            {"~", "-"},
            {"[", "("},
            {"]", ")"},
            {"{", "("},
            {"}", ")"},
            {"|", "-"},
            {"€", "E"},
            {"^", "-"}
        };

        var someString = "@${} t€st";
        var bannedSigns = string.Join("", bannedSignsAndReplacements.Select(sg => sg.Key));

        var curedString = 
            Regex.Replace(someString, $@"[{bannedSigns}]", delegate (Match match)
            {
                string val = match.ToString();
                return bannedSignsAndReplacements[val];
            });

        Console.WriteLine(curedString);
    }
}

So as you see I am having collection of banned signs and replacements for them, I am putting it into this reggex expression and I have 2 scenarios:

when i use @${} t€st this string I regex trying to replace ${} I think it treats it like a single char
when I remove ${} it ignores any pattern

So probably my pattern is wrong but Have no idea how to bite this problem. Any Ideas?

You forgot to `Regex.Escape()` each of the `bannedSigns` :-) `.Select(sg => sg.Key)` -> `.Select(sg => Regex.Escape(sg.Key))` — Mathias R. Jessen, Jan 28 '21 at 14:37
No need for regex: `foreach(var kv in bannedSignsAndReplacements) someString=someString.Replace(kv.Key, kv.Value);` — Tim Schmelter, Jan 29 '21 at 08:19

Reaplace many chars in string using c#

0 Answers0