SQL Max Pool Reached. C# OPTIMIZE READER

Question

I need to clode the Connection (conn.Close();) ater reading SQL

Heres the Reader

public MySqlDataReader ExecuteReader(string sql)
{
    try
    {
        
        MySqlDataReader reader;

        MySqlCommand cmd = new MySqlCommand(sql, conn);
        reader = cmd.ExecuteReader();
        
        return reader;
        


    }
    catch (Exception ex)
    {
        Console.WriteLine(ex.Message);
    }
    return null;
}

Where do i need to put the Close line?

David Browne - Microsoft · Answer 1 · 2021-02-01T00:29:35.997

1

Either load and return a DataTable using DataTable.Load(IDataReader) instead of a DataReader, and put the Connection in a using block, or use CommandBehavior.CloseConnection and when the DataReader is closed the Connection will be too.

edited Feb 01 '21 at 00:29

answered Jan 31 '21 at 22:29

David Browne - Microsoft

80,331
6
39
67

Hey, what about a proper `using` block for connection, command and reader? – Charlieface Jan 31 '21 at 23:45
With the function that returns DataTable sure. But when returning a DataReader you can't close the Connection. The calling code should wrap the returned DataReader in a `using` block. – David Browne - Microsoft Feb 01 '21 at 00:30

SQL Max Pool Reached. C# OPTIMIZE READER

1 Answers1