If statement gives "[: too many arguments" when grep pattern is found

Asked Feb 01 '21 at 17:58

Active Feb 01 '21 at 17:59

Viewed 22 times

I'm trying to make a bash script where it searches for a pattern in different files (they start all with the same word).

The script works but gives an error when the pattern is found ("[: too many arguments") and after the error it gives the result that I'm looking for. When the pattern is not found, the error does not show up. So how do I get rid of the error when the pattern is found?

#!/bin/bash

#Look for sample with their barcode

echo "Wich sample are you looking for?"
read barcode

pattern=$(grep $barcode samples*)

if [ -z $pattern ]

then echo "$barcode did not yet arrive."
else echo "$pattern"

fi

edited Feb 01 '21 at 17:59

John Kugelman

349,597
67
533
578

asked Feb 01 '21 at 17:58

Simon Haesaerts

Quotes matter. `[ -z "$pattern" ]` -- also, `grep "$barcode" samples*` – Charles Duffy Feb 01 '21 at 18:00
1

Consider running your code through http://shellcheck.net/ and fixing issues it identifies before asking questions here. – Charles Duffy Feb 01 '21 at 18:01
thanks, did not know about that site. still new to programming – Simon Haesaerts Feb 01 '21 at 18:05
1

It's also a tool you can install on your own machine, not just a website. – Charles Duffy Feb 01 '21 at 18:05
1

Since you're using `bash`, use `[[` ... `]]` and you don't need to quote the variable: `if [[ -z $pattern ]]` – Ted Lyngmo Feb 01 '21 at 18:16

If statement gives "[: too many arguments" when grep pattern is found

0 Answers0