Issue when using a loop for accordion with JQuery event

Question

Hello I have a problem with this code:

for(var element in partsListById)
{
    $('.title#'+partsListById[element]).on('click touch', function(e){
        $('.part#'+partsListById[element]).slideToggle();
    });
}

the partsListById array contains a string list of the name of the objects I want to target.

I don't understand why the code above doesn't work and this one works:

$('.title#sensor').on('click touch', function(e){
    $('.part#sensor').slideToggle();
});

Where is my mistake?

I'm realy new in JS.

Can you help me?

Thank you

https://stackoverflow.com/questions/750486/javascript-closure-inside-loops-simple-practical-example — epascarello, Feb 09 '21 at 17:59
It is really bad to have multiple elements on the page with the same id. — epascarello, Feb 09 '21 at 18:00
Seems like you really do not need the loop. Something like the following would probably work. `$('.title').on('click touch', function(e){ $('.part#'+this.id).slideToggle(); });` — epascarello, Feb 09 '21 at 18:02

score 0 · Accepted Answer · answered Feb 09 '21 at 18:15

0

Use let or const so that the variable is local to the loop block.

for(const element in partsListById)

answered Feb 09 '21 at 18:15

Unmitigated

76,500
11
62
80

score 0 · Answer 2 · answered Feb 09 '21 at 20:03

0

This is because the loop is not executed, that is, the Value of "partsListById" is empty. First Check the Value "partsListById"

console.log(partsListById);

if is null the loop is not executed.

answered Feb 09 '21 at 20:03

Jalal Malekpour

19
8

Issue when using a loop for accordion with JQuery event

2 Answers2