Stop an NSRunLoop from a timer

Question

I've made a RunLoop with a timer that updates a label that displays a countdown. I need the RunLoop to stop once the countdown reaches zero, for the case where the the timer finishes normally I could just use runUntilDate, with the date being the current date + the time on the countdown. The problem is when the user cancels the countdown from a button before it's finished. I don't know how to tell the RunLoop to stop from the cancel button action. Here's the code for the RunLoop:

    NSInvocation *invocation = [NSInvocation invocationWithMethodSignature:
                            [self methodSignatureForSelector:@selector(updateCountdownLabel:)]];
[invocation setTarget:self];
[invocation setSelector:@selector(updateCountdownLabel:)];
[[NSRunLoop mainRunLoop] addTimer:[NSTimer timerWithTimeInterval:1 invocation:invocation repeats:YES] forMode:NSRunLoopCommonModes];

The method just tells the label to reduce by 1 in each loop.

I could tell the cancel button to change the label to zero, and have the run loop selector check if the value is zero, but could the RunLoop's own selector tell it to stop?

cancelPerformSelector:target:argument:

cancelPerformSelectorsWithTarget:

These are the closest I've found but they don't seem to work from inside the RunLoops own selector, or at least not in any way I've tried them.

Basically I need to have the button tell the RunLoop to stop, or somehow stop the RunLoop from it's own selector.

Thanks.

A selector is simply the name of a method. I've corrected your usages of the word in my edit. — Peter Hosey, Jul 08 '11 at 07:11

Rob Keniger · Accepted Answer · 2011-07-09T00:48:29.127

13

You haven't made a run loop, you've scheduled a timer to begin on the main run loop.

What you should do is store the NSTimer object that you create as an instance variable before scheduling the timer on the run loop.

In your updateCountdownLabel: method, once your end condition has been satisfied just call -invalidate on your timer instance. This will remove the timer from the run loop, and because you never retained it, it will be released.

I've updated the methods to use a selector-based NSTimer rather than your NSInvocation-based one. This means that the callback method signature is defined as you are expecting. It also avoids the need to store the NSTimer object in an ivar:

- (void)startCountDown
{

    NSTimer* timer = [NSTimer timerWithTimeInterval:1.0 target:self selector:@selector(updateCountdownLabel:) userInfo:nil repeats:YES]
    [[NSRunLoop mainRunLoop] addTimer:timer forMode:NSRunLoopCommonModes];
}


- (void)updateCountdownLabel:(NSTImer*)timer
{
    if(thingsAreAllDone)
    {
        [timer invalidate];
    }
}

edited Jul 09 '11 at 00:48

answered Jul 08 '11 at 06:56

Rob Keniger

45,830
6
101
134

That doesn't seem to be working, where you use "(id)anArg", what should really go there? I always put the timer. In this case, i have "- (void) updateCountdownLabel:(NSTimer *) timer", never tried putting anything different before, but when I do it as I mentioned, whenever I use the timer variable i get a warning for "Local declaration of timer hides instance variable". For the if statement I'm just checking if the label is smaller or equal to zero. This code doesn't throw an error but it doesn't stop the label from counting down to the negatives. Any ideas? – Elbimio Jul 08 '11 at 22:51
I've updated the code to use a selector-based `NSTimer`, which should give you the result you want. – Rob Keniger Jul 09 '11 at 00:53
Found the problem. I just needed a variable to save the number on the label as an int and then use THAT in the if. Thanks! – Elbimio Jul 09 '11 at 00:59
This does only work when it fires "updateCountdownLabel" the first time and you immediately call invalidate on the timer. If it has fired "updateCountdownLabel" multiple times and than decides to invalidate the timer, than either it won't remove from the NSRunLoop or NSRunLoop has another input source behind the scene. – AndaluZ Mar 01 '19 at 08:13

Stop an NSRunLoop from a timer

1 Answers1