Check if parameter does NOT match regex with two possible values?

Question

Here is what I'm trying to do in one of my bash scripts.

If SERVER_ENV is not PROD or TEST, the script must exit.

check-server-env() {
  local SERVER_ENV="$1"
  if ! [[ "$SERVER_ENV"^^ =~ ^(TEST|PROD)$ ]]; then
    error "$(highlight "$SERVER_ENV")" " does not exist."
    echo "Exiting script..."
    echo ""
    exit 0
  fi
}

I call script.sh TEST

SERVER_ENV=$1

check-server-env $SERVER_ENV

Here is how I'm calling. And it's not working. What am I doing wrong?

@RamanSailopal To make sure it's uppercase? I think I've tried without it as well. — cbdeveloper, Feb 16 '21 at 15:41
The regex is not necessary. You can just do `if [ "$SERVER_ENV" != TEST ] && [ "$SERVER_ENV" != PROD ]; then ...`. — Shane Bishop, Feb 16 '21 at 15:42
@ShaneBishop I guess it would also work. But I'd like to do it using regex. Thanks! — cbdeveloper, Feb 16 '21 at 15:45
As pointed out by @anubhava, that's the wrong way to make a string uppercase in bash. The correct way is `"${SERVER_ENV^^}"` (note the `{` and `}`). — Shane Bishop, Feb 16 '21 at 15:45
Also I don't understand `regex` tag removal rationale. If OP wants a regex help what's wrong with having it in question? — anubhava, Feb 16 '21 at 15:52
This new linked question is also not really a dupe. *match regex with two possible values* is different from *string begins with some value* and linked question has no mention of `extglob` answer as well — anubhava, Feb 17 '21 at 09:20

score 6 · Accepted Answer · edited Feb 17 '21 at 06:18

You may use:

check-server-env() {
  local SERVER_ENV="$1"

  if [[ ! "${SERVER_ENV^^}" =~ ^(TEST|PROD)$ ]]; then
    error "$(highlight "$SERVER_ENV")" " does not exist."
    echo "Exiting script..."
    echo ""
    exit 0
  fi
}

However you may ditch regex and use extglob matching in bash:

check-server-env() {
  local SERVER_ENV="$1"

  if [[ "${SERVER_ENV^^}" != @(TEST|PROD) ]]; then
    error "$(highlight "$SERVER_ENV")" " does not exist."
    echo "Exiting script..."
    echo ""
    exit 0
  fi
}

MonkeyZeus · Answer 2 · 2021-02-16T15:52:07.090

1

Why use regex at all?

if [ "${SERVER_ENV^^}" != "PROD" ] && [ "${SERVER_ENV^^}" != "TEST" ]; then
    error "$(highlight "$SERVER_ENV")" " does not exist."
    echo "Exiting script..."
    echo ""
    exit 0
fi

edited Feb 16 '21 at 15:52

answered Feb 16 '21 at 15:45

MonkeyZeus

20,375
4
36
77

This condition won't match the OP's desired logic. – Shane Bishop Feb 16 '21 at 15:46
@ShaneBishop thanks for catching that, fixed! – MonkeyZeus Feb 16 '21 at 15:47
Still not fixed - you need `&&`. Quoting the OP: "If SERVER_ENV is not PROD or TEST, the script must exit." Here the English language is being ambiguous, but the English "not ... or" in this case translates to `&&` in bash, because of De Morgan's law. (The English sentence translates to "not (x or y)", which De Morgan's law translates to "(not x) and (not y)"). – Shane Bishop Feb 16 '21 at 15:50

Check if parameter does NOT match regex with two possible values?

2 Answers2