1

I am asked to create a function that takes a string to check whether the string is valid or not.

A valid string has the following conditions.

Exactly 4 or 6 characters.

Only numerical characters (0-9).

No whitespace

My solution does not work.

function test(num){
  return num.length === 4 || num.length === 6;
}

console.log(test("123445"),true);

console.log(test("801264"),true);

console.log(test("451352"),true);

console.log(test("881234"),true);

console.log(test("as89abc1"),false);

console.log(test("    "),false);

console.log(test(" 4983 "),false);

console.log(test("123 "),false);
  • 1
    You are only checking for length. There are plenty of questions about checking [whether a string has only numerical characters](https://stackoverflow.com/questions/1779013/check-if-string-contains-only-digits). The space check is not required because the check for numbers already covers it. – adiga Feb 21 '21 at 11:06

1 Answers1

2

You are only checking the length of the string, and not if it consists of only digits.

You might also use a pattern to check for 4 or 6 digits

const test = num => /^(?:\d{4}|\d{6}$)/.test(num);

[
  "123445",
  "801264",
  "451352",
  "881234",
  "as89abc1",
  "    ",
  " 4983 ",
  "123 "
].forEach(s => console.log(`${s} ==> ${test(s)}`));
The fourth bird
  • 154,723
  • 16
  • 55
  • 70