Showing values in an array

Question

I have been coding another programming challenge from a book. It is about asking a user to input n numbers inside an array. Every time the user inputs, the current numbers entered should show up. Numbers less than or equal to zero should not be accepted. I have managed to do the first condition. However, it even shows the "empty" slots. I have tMy code will explain it. Here:

#include <iostream>
using namespace std;
int main() {
    int size = 0, input_num [100], i, j;
    
    cout << "Enter an array size: ";
    cin >> size;
        if (size <= 0) {
            while (size <= 0) {
               cout << "Enter an array size again: ";
               cin >> size;
            } 
        }
       
    cout << "\n\nYou may now enter " << size << " numbers ";
    cout << "\n------ ------ ------ ------\n";
    
    for (i = 0; i < size; i++) {
        cout << "Enter a number: ";
        cin >> input_num [i];
       
         cout << "\nEntered Numbers: ";
            for (j = 0; j < size; j++) {
                cout << input_num [j] << "  " ;
            }
        cout << "\n";
        
    }
 
}

There are no _empty_ elements in a raw array, What would you expect to be there to distinguish valid from invalid elements? — πάντα ῥεῖ, Mar 21 '21 at 07:40
Unrelated to your issue, but you don't need the `if (size <= 0)` check, it's included in the `while (size <= 0)`. — Some programmer dude, Mar 21 '21 at 07:43
More related to your problem, the display loop should not be inside the input loop. — Some programmer dude, Mar 21 '21 at 07:44
Lastly, think about what happens if the user enters a value larger than `100` for `size`. Or a negative number. — Some programmer dude, Mar 21 '21 at 07:55

score 1 · Answer 1 · answered Mar 21 '21 at 07:44

1

In your output section, it should be j <= i, not j < size.

cout << "\nEntered Numbers: ";
for (j = 0; j <= i; j++) {
    cout << input_num [j] << "  " ;
}
cout << "\n";

answered Mar 21 '21 at 07:44

Feng BLn

11
1

Showing values in an array

1 Answers1