Requests library and except

Question

everybody. I'm learning Python from a few weeks. I have a problem with the requests library. I wrote a short code which asks for a website address. If the page exists, it is written to the file good.txt, if it does not exist it should be written to the wrong.txt file. What's wrong with this code?

import requests


website = input('First website to check:  ')

website1 = 'http://'+website

a = requests.get(website1)



try:
    a.status_code  == 200
    with open("good.txt", "a", encoding = "UTF-8") as file:
         file.write(website1)

except requests.RequestException:
    with open("wrong.txt", "a", encoding = "UTF-8") as file:
         file.write(website1)

Thanks for the advice.

Please add an error or exception that you are getting – Dima Daron Apr 04 '21 at 19:45 — Dima Daron, Apr 04 '21 at 19:45

badcod3r · Answer 1 · 2021-04-04T19:44:00.733

0

You need to make an if statement

try:
    a = requests.get(website1)
    if a.status_code  == 200:
        with open("good.txt", "a", encoding = "UTF-8") as file:
            file.write(website1)
    else:
        with open("wrong.txt", "a", encoding = "UTF-8") as file:
            file.write(website1)

except requests.RequestException:
    with open("wrong.txt", "a", encoding = "UTF-8") as file:
        file.write(website1)

Edit: also fixed your try catch code

edited Apr 04 '21 at 19:44

answered Apr 04 '21 at 19:33

badcod3r

61
3

Or the OP can use `a.raise_for_status()` and keep the try/except... – Jon Clements Apr 04 '21 at 19:37
Yes I know. But I wanted to try to fix the problem with: try and except. Is there such a solution? – mateoo88 Apr 04 '21 at 19:37
Have a look at https://stackoverflow.com/questions/16511337/correct-way-to-try-except-using-python-requests-module @mateoo88 – Jon Clements Apr 04 '21 at 19:42

score 0 · Accepted Answer · answered Apr 04 '21 at 19:35

Using your try/except block, you have to make the request in the try block.

import requests


website = input('First website to check:  ')

website1 = 'http://'+website
try:
    a = requests.get(website1)
    a.status_code  == 200
    with open("good.txt", "a", encoding = "UTF-8") as file:
         file.write(website1)

except requests.RequestException:
    with open("wrong.txt", "a", encoding = "UTF-8") as file:
         file.write(website1)

Requests library and except

2 Answers2