0

I made a custom JTextField to input numeric values. The class looks as follows:

import javax.swing.*;
import java.awt.*;
import java.awt.event.KeyEvent;

public class JNumberField extends JTextField {

    public JNumberField(int width, int height) {
        this();
        setPreferredSize(new Dimension(width, height));
    }

    public JNumberField() {
        setFont(new Font("Monospace", Font.BOLD, 23));
        setHorizontalAlignment(JTextField.HORIZONTAL);
    }

    @Override
    public void processKeyEvent(KeyEvent ev) {
        //Accepts digits, backspace, minus key and left/right arrow keys
        if (Character.isDigit(ev.getKeyChar()) || ev.getKeyCode() == KeyEvent.VK_BACK_SPACE || ev.getKeyCode() == KeyEvent.VK_MINUS || ev.getKeyCode() == KeyEvent.VK_LEFT || ev.getKeyCode() == KeyEvent.VK_RIGHT) {
            super.processKeyEvent(ev);
        }
        ev.consume();
    }

    public static void main(String[] args) {
        JOptionPane.showInputDialog(new JNumberField(300,50));
    }
}

All the keys are working except for the "-" key. I also printed the keycode that was pressed and it responded with 45 so the if statement is executed but it doesn't insert the - into the text field. Is this a bug or how can it be fixed? I also tried removing the if statement and just call the processKeyEvent method and then it works to insert the - sign...

Teh Swish
  • 99
  • 1
  • 12
  • 1
    *"to input numeric values"* I'd offer the user a (standard) `JSpinner` with a `SpinnerNumberModel`. (Likely) problem solved, with a better user experience to boot. – Andrew Thompson Apr 09 '21 at 15:57
  • 1
    But general comments.. 1) People often reach for a `KeyListener` when, for Swing, a key binding would work better. Having said that.. 2) People often try arcane ways to filter a text field when they should be using a `JFormattedTextField` (See [how to..](https://docs.oracle.com/javase/tutorial/uiswing/components/formattedtextfield.html)). 3) For better help sooner, [edit] to add a [MCVE] or [Short, Self Contained, Correct Example](http://www.sscce.org/). The code above would likely only need imports and a `main` method to show the text field in an option pane, to fulfil the MRE/SSCCE spec. – Andrew Thompson Apr 09 '21 at 16:01
  • Sure, maybe something else works better than this, but my question is why this doesn't work? – Teh Swish Apr 09 '21 at 16:11
  • *"..why this doesn't work?"* Oh, I don't know. Further, given the many better alternatives, probably the only extent to which I'd care to look into it would be to load up and look at the MRE / SSCCE after I'd thrown the app. on-screen and confirmed the behavior. Where is that MRE / SSCCE BTW? – Andrew Thompson Apr 09 '21 at 16:17
  • I edited the example for you. – Teh Swish Apr 09 '21 at 16:38

1 Answers1

3

First of all I totally agree with Andrew, there are better solutions to solving the problem. For example you can use:

  1. a JSpinner
  2. a JFormattedTextField
  3. a DocumentFilter - see: How to automatically update small letter characters to capital letter in Java JEditorPane?

The reason the above solutions are better is because:

  1. you don't need to extend a class
  2. the solutions are more abstract

Your solution is a low level solution, which means you need to understands the events that are generated when you press a key and how those events are handled by Swing.

A more abstract solution is always better since you don't need to know the details. This is why the Swing API has evolved.

In your case you are not understanding the difference between a "displayable" key event and a "non displayable" event.

A text component is updated when the keyTyped event is generated which is only generated for "displayable" character like " numeric digits" and "-".

A "keyTyped" event is not generated for using the arrow keys or backspace keys.

So your logic needs to be changed to handle the "-" as a character (not a key code):

//if (Character.isDigit(ev.getKeyChar()) || ev.getKeyCode() == KeyEvent.VK_MINUS ...
if (Character.isDigit(ev.getKeyChar()) || ev.getKeyChar() == '-' ...
camickr
  • 321,443
  • 19
  • 166
  • 288